Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unreadable non-UTF-8 output on localized MSVC #110586

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Fix Unreadable non-UTF-8 output on localized MSVC #110586

merged 2 commits into from
Apr 30, 2023

Commits on Apr 27, 2023

  1. Fix Unreadable non-UTF-8 output on localized MSVC 

    Fixes rust-lang#35785 by converting non UTF-8 linker output to Unicode using the OEM code page.

Before:

```text
  = note: Non-UTF-8 output: LINK : fatal error LNK1181: cannot open input file \'m\x84rchenhaft.obj\'\r\n
```

After:

```text
   = note: LINK : fatal error LNK1181: cannot open input file 'märchenhaft.obj'

```

The difference is more dramatic if using a non-ascii language pack for Visual Studio.
    @ChrisDenton
    ChrisDenton committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    73b6574 View commit details
    Browse the repository at this point in the history

  2. Abstract MultiByteToWideChar

    @ChrisDenton
    ChrisDenton committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    9b9d39e View commit details
    Browse the repository at this point in the history