Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling library #110419

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Spelling library #110419

merged 3 commits into from
Apr 26, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 16, 2023

Split per #110392

I can squash once people are happy w/ the changes. It's really uncommon for large sets of changes to be perfectly acceptable w/o at least some changes.

I probably won't have time to respond until tomorrow or the next day

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

jsoref
jsoref commented Apr 16, 2023
View reviewed changes
library/core/src/intrinsics.rs Show resolved Hide resolved
library/core/src/macros/panic.md Show resolved Hide resolved
library/std/src/io/buffered/tests.rs Outdated Show resolved Hide resolved
library/std/src/io/buffered/tests.rs Outdated Show resolved Hide resolved
library/std/src/keyword_docs.rs Show resolved Hide resolved
library/std/src/sys/unix/process/process_unix.rs Show resolved Hide resolved
cuviper
cuviper reviewed Apr 20, 2023
View reviewed changes
library/alloc/tests/slice.rs Outdated Show resolved Hide resolved
library/std/src/sys/itron/error.rs Outdated Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Apr 26, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 26, 2023

📌 Commit 9d2d40d2640c7cf9f328d035099e209b6c99b108 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
@compiler-errors
Copy link
Member

@bors r-

This needs to be squashed

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 26, 2023
@jsoref
Spelling library/
9cb9346 
* advance
* aligned
* borrowed
* calculate
* debugable
* debuggable
* declarations
* desugaring
* documentation
* enclave
* ignorable
* initialized
* iterator
* kaboom
* monomorphization
* nonexistent
* optimizer
* panicking
* process
* reentrant
* rustonomicon
* the
* uninitialized

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
rewrite: long_line_flushed description
1042b2c 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
rewrite: line_long_tail_not_flushed description
9a55e9e 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Copy link
Contributor Author

jsoref commented Apr 26, 2023

Do you want the rewrite bits to be in the same commit? (If so, do you have any preference wrt the commit message?)

@compiler-errors
Copy link
Member

Don't mind if you just squash the single word commits, otherwise use your intuition for commit naming 😃

@jsoref
Copy link
Contributor Author

jsoref commented Apr 26, 2023

Alright, let's leave it as is, one commit for the single word stuff, and distinct commits for the rewrites as they're individually interesting

@jyn514
Copy link
Member

jyn514 commented Apr 26, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2023

📌 Commit 9a55e9e has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 26, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2023
@bors
Auto merge of rust-lang#110852 - matthiaskrgr:rollup-jz3eosr, r=matth…
1c42cb4 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#108760 (Add lint to deny diagnostics composed of static strings)
 - rust-lang#109444 (Change tidy error message for TODOs)
 - rust-lang#110419 (Spelling library)
 - rust-lang#110550 (Suggest deref on comparison binop RHS even if type is not Copy)
 - rust-lang#110641 (Add new rustdoc book chapter to describe in-doc settings)
 - rust-lang#110798 (pass `unused_extern_crates` in `librustdoc::doctest::make_test`)
 - rust-lang#110819 (simplify TrustedLen impls)
 - rust-lang#110825 (diagnostics: add test case for already-solved issue)
 - rust-lang#110835 (Make some region folders a little stricter.)
 - rust-lang#110847 (rustdoc-json: Time serialization.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9babe98 into rust-lang:master Apr 26, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 26, 2023
@jsoref jsoref deleted the spelling-library branch April 26, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper left review comments

@setharnold setharnold setharnold left review comments

@saethlin saethlin saethlin left review comments

Assignees

@cuviper cuviper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
8 participants
@jsoref @rustbot @jyn514 @bors @compiler-errors @cuviper @setharnold @saethlin