Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support x fmt for sub and outside of rust directories #108404

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

onur-ozkan
Copy link
Member

This PR makes x fmt to be succesfully work from sub or outside dir of rust.

The following cases are tested and the results were successful.

# from rust/library directory
../x fmt compiler --check
../x fmt compiler/rustc

# from outside of rust directory
../../rust/x fmt library/std library/core --check
../../rust/x fmt library/std

Resolves #108004

r? @albertlarsan68

Signed-off-by: ozkanonur <work@onurozkan.dev>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 23, 2023
@jyn514
Copy link
Member

jyn514 commented Feb 23, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 23, 2023

📌 Commit 49516b3 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 24, 2023
support `x fmt` for sub and outside of rust directories

This PR makes `x fmt` to be succesfully work from sub or outside dir of rust.

The following cases are tested and the results were successful.
```sh
# from rust/library directory
../x fmt compiler --check
../x fmt compiler/rustc

# from outside of rust directory
../../rust/x fmt library/std library/core --check
../../rust/x fmt library/std
```

Resolves rust-lang#108004

r? `@albertlarsan68`
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108354 (Update `fuchsia-test-runner.py` and docs)
 - rust-lang#108404 (support `x fmt` for sub and outside of rust directories)
 - rust-lang#108407 (docs: use intra-doc links for `Vec::get(_mut)`)
 - rust-lang#108410 (rustdoc: avoid including `<li>` tags in item table short desc)
 - rust-lang#108412 (Fix GUI test navigation bug)
 - rust-lang#108433 (Wrap missing provider message correctly)
 - rust-lang#108434 (Migrate `rustc_hir_analysis` to session diagnostic [Part One])

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 91a8496 into rust-lang:master Feb 25, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 25, 2023
@onur-ozkan onur-ozkan deleted the 108004 branch January 27, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support x fmt for sub and outside of rust directories
5 participants