Make x doc --open work on every book
#108394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Seems we have an error in CI pipeline @rustbot author |
rustbot
added
S-waiting-on-author
|
@bors review |
|
@rustbot review |
rustbot
added
S-waiting-on-review
|
When |
|
That is the current behavior for the books that already support |
onur-ozkan
approved these changes
Mar 1, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#108143 (rustdoc: search by macro when query ends with `!`) - rust-lang#108394 (Make `x doc --open` work on every book) - rust-lang#108427 (Recover from for-else and while-else) - rust-lang#108462 (Fix `VecDeque::append` capacity overflow for ZSTs) - rust-lang#108568 (Make associated_item_def_ids for traits use an unstable option to also return associated types for RPITITs) - rust-lang#108604 (Add regression test for rust-lang#107280) - rust-lang#108605 (Add regression test for rust-lang#105821) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the
--openflag had to be configured explicitly for every book, and most of them didn't configure it, resulting in the flag silently failing in all but two books.In this PR, the code to check for the
--openflag is in the underlyingRustbookSrcstep rather than all the individual steps. This is done by passing the parent step as a field ofRustbookSrc, so that we can check for the correct step inmaybe_open_in_browser.This was part of a larger change that in the end wasn't worth it. Still, I think it could be useful as-is.