Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always resolve to universal regions if possible #108121

Merged
merged 7 commits into from
Mar 8, 2023
Merged

always resolve to universal regions if possible #108121

merged 7 commits into from
Mar 8, 2023

Commits on Mar 5, 2023

  1. resolve to universal regions when possible

    @aliemjay
    aliemjay committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    f3dfa52 View commit details
    Browse the repository at this point in the history

  2. s/unification_table/unification_table_mut 

    Give a more clear name.
    @aliemjay
    aliemjay committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    79dca7b View commit details
    Browse the repository at this point in the history

  3. oops! new unsoundness 

    Bless tests and show an introduced unsoundness related to
exits<'a> { forall<'b> { 'a == 'b } }.
We now resolve the var ?a in U0 to the placeholder !b in U1.
    @aliemjay
    aliemjay committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    eea5604 View commit details
    Browse the repository at this point in the history

  4. fix the new unsoundness

    @aliemjay
    aliemjay committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    bfd3501 View commit details
    Browse the repository at this point in the history

  5. bless rustdoc tests

    @aliemjay
    aliemjay committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    095b5fa View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. address review comment

    @aliemjay
    aliemjay committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    228f408 View commit details
    Browse the repository at this point in the history

  2. prefer universal from lower universe 

    In case a variable is unified with two universal regions from different
universes, use the one with the lower universe as it has a higher chance
of being compatible with the variable.
    @aliemjay
    aliemjay committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    0b232d0 View commit details
    Browse the repository at this point in the history