Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #107143

Merged
merged 29 commits into from
Jan 21, 2023
Merged

Rollup of 9 pull requests #107143

merged 29 commits into from
Jan 21, 2023

Commits on Nov 20, 2022

  1. Unify stable and unstable sort implementations in same core module

    This moves the stable sort implementation to the core::slice::sort module. By
    virtue of being in core it can't access `Vec`. The two `Vec` used by merge sort,
    `buf` and `runs`, are modelled as custom types that implement the very limited
    required `Vec` interface with the help of provided allocation and free
    functions. This is done to allow future re-use of functions and logic between
    stable and unstable sort. Such as `insert_head`.
    Voultapher committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    dbc0ed2 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Remove debug unused

    Voultapher committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    1ec59cd View commit details
    Browse the repository at this point in the history
  2. Document all unsafe blocks

    There were several unsafe blocks in the existing implementation that
    were not documented with a SAFETY comment.
    Voultapher committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    4b5844f View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Configuration menu
    Copy the full SHA
    280f69d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c9c8e29 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aee75f2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f53f5b4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    69890b2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ed6aebb View commit details
    Browse the repository at this point in the history
  7. rustdoc: remove redundant CSS selector .sidebar .current

    Since the current sidebar item is already a link, it doesn't
    do anything.
    notriddle committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    05889fc View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Change bindings_with_variant_name to deny-by-default

    timrobertsdev authored and Tim Roberts committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    734f375 View commit details
    Browse the repository at this point in the history
  2. Add compile_fail to doctest for bindings_with_variant_name

    timrobertsdev authored and Tim Roberts committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    1cbce72 View commit details
    Browse the repository at this point in the history
  3. Fix typo in opaque_types.rs

    paramters -> parameters
    eltociear committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    1adb4d6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    540ca2f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a641b92 View commit details
    Browse the repository at this point in the history
  6. rustdoc: use CSS inline layout for radio line instead of flexbox

    This uses less code to lay them out the same way.
    notriddle committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    112d85c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e9d8d23 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e237690 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    dca160a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c07a722 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Rollup merge of rust-lang#104154 - timrobertsdev:deny-by-default-bind…

    …ings_with_variant_name, r=scottmcm
    
    Change `bindings_with_variant_name` to deny-by-default
    
    Changed the `bindings_with_variant_name` lint to deny-by-default and fixed up the affected tests.
    
    Addresses rust-lang#103442.
    compiler-errors committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    e640069 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#104347 - notriddle:notriddle/import-macro-f…

    …rom-self-fixup, r=TaKO8Ki
    
    diagnostics: suggest changing `s@self::{macro}@::macro` for exported
    
    Fixes rust-lang#99695
    compiler-errors committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    bf75f81 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#104672 - Voultapher:unify-sort-modules, r=t…

    …homcc
    
    Unify stable and unstable sort implementations in same core module
    
    This moves the stable sort implementation to the core::slice::sort module. By virtue of being in core it can't access `Vec`. The two `Vec` used by merge sort, `buf` and `runs`, are modelled as custom types that implement the very limited required `Vec` interface with the help of provided allocation and free functions. This is done to allow future re-use of functions and logic between stable and unstable sort. Such as `insert_head`.
    
    This is in preparation of rust-lang#100856 and rust-lang#104116. It only moves code, it *doesn't* change any of the sort related logic. This unlocks the ability to share `insert_head`, `insert_tail`, `swap_if_less` `merge` and more.
    
    Tagging ````@Mark-Simulacrum```` I hope this allows progress on rust-lang#100856, by moving `merge_sort` here I hope future changes will be easier to review.
    compiler-errors committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    68b390a View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#107048 - DebugSteven:newer-x-check-cargo, r…

    …=albertlarsan68
    
    check for x version updates
    
    This PR adds a check to tidy to assert that the installed version of `x` is equal to the version in `src/tools/x/Cargo.toml`. It checks the installed version of `x` by parsing the output of `cargo install --list` (as an option proposed in this [issue](rust-lang#106469)).
    
    It does not warn if `x` has not yet been installed, on the assumption that the user isn't interested in using it.
    compiler-errors committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    d26c88c View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#107061 - compiler-errors:new-solver-new-can…

    …didates-3, r=lcnr
    
    Implement some more new solver candidates and fix some bugs
    
    First, fix some bugs:
    
    1. `IndexVec::drain_enumerated(a..b)` does not give us an iterator of index keys + items enumerated from `a..b`, but from `0..(b-a)`... That caused a bug. See first commit for the fix.
    2. Implement the `_: Trait` ambiguity hack. I put it in assemble, let me know if it should live elsewhere. This is important, since we otherwise consider `_: Sized` to have no solutions, and nothing passes!
    3. Swap `Ambiguity` and `Unimplemented` cases for the new solver. Sorry for accidentally swapping them 😄
    4. Check GATs' own predicates during projection confirmation.
    
    Then implement a few builtin traits:
    
    5. Implement `PointerSized`. Pretty independent.
    6. Implement `Fn` family of traits for fnptr, fndef, and closures. Closures are currently broken because `FulfillCtxt::relationships` is intentionally left unimplemented. See comment in the test.
    
    r? ```@lcnr```
    compiler-errors committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    3452104 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#107095 - notriddle:notriddle/sidebar-curren…

    …t, r=GuillaumeGomez
    
    rustdoc: remove redundant CSS selector `.sidebar .current`
    
    Since the current sidebar item is already a link, it doesn't do anything.
    compiler-errors committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    7565b9a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#107112 - eltociear:patch-19, r=albertlarsan68

    Fix typo in opaque_types.rs
    
    paramters -> parameters
    compiler-errors committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    7168aa5 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#107124 - DebugSteven:check-macro-expansion,…

    … r=albertlarsan68
    
    fix check macro expansion
    
    If the only argument to `check!` is the module name I get this error:
    
    ```
    error: expected expression, found `,`
       --> src/tools/tidy/src/main.rs:63:42
        |
    57  | /         macro_rules! check {
    58  | |             ($p:ident $(, $args:expr)* ) => {
    59  | |                 drain_handles(&mut handles);
    60  | |
    ...   |
    63  | |                     $p::check($($args),* , &mut flag);
        | |                                          ^ expected expression
    ...   |
    69  | |             }
    70  | |         }
        | |_________- in this expansion of `check!`
    ...
    117 |           check!(hey);
        |           ----------- in this macro invocation
    ```
    
    This change makes it so commas are added only when there are `args`.
    
    r? ```@albertlarsan68```
    compiler-errors committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    a4f0126 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#107131 - notriddle:notriddle/rustdoc-radio-…

    …display-inline-flex, r=GuillaumeGomez
    
    rustdoc: use CSS inline layout for radio line instead of flexbox
    
    This uses less code to lay them out the same way. Already tested here:
    
    https://github.com/rust-lang/rust/blob/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/tests/rustdoc-gui/settings.goml#L123
    compiler-errors committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    34d4df5 View commit details
    Browse the repository at this point in the history