add tests for div_duration_* functions #106570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rustbot
added
the
T-libs
JohnTitor
approved these changes
Jan 9, 2023
|
Awesome, thank you! @bors r+ |
|
@bors r+ |
bors
added
S-waiting-on-bors
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Jan 10, 2023
…Titor add tests for div_duration_* functions Per rust-lang#63139 (comment) this adds unit tests for the functions that will hopefully effectively demonstrate that `div_duration` is ready to be stabilized.
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
Jan 11, 2023
…Titor add tests for div_duration_* functions Per rust-lang#63139 (comment) this adds unit tests for the functions that will hopefully effectively demonstrate that `div_duration` is ready to be stabilized.
This was referenced Jan 11, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 11, 2023
Rollup of 9 pull requests Successful merges: - rust-lang#106321 (Collect and emit proper backtraces for `delay_span_bug`s) - rust-lang#106397 (Check `impl`'s `where` clauses in `consider_impl_candidate` in experimental solver) - rust-lang#106427 (Improve fluent error messages) - rust-lang#106570 (add tests for div_duration_* functions) - rust-lang#106648 (Polymorphization cleanup) - rust-lang#106664 (Remove unnecessary lseek syscall when using std::fs::read) - rust-lang#106709 (Disable "split dwarf inlining" by default.) - rust-lang#106715 (Autolabel and ping wg for changes to new solver) - rust-lang#106717 (fix typo LocalItemId -> ItemLocalId) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #63139 (comment)
this adds unit tests for the functions that will hopefully effectively demonstrate that
div_durationis ready to be stabilized.