Fix rustdoc source code rendering for #[path = "../path/to/mod.rs"] links
#106466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @notriddle (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
clubby789
force-pushed
the
relative-module-fix
branch
from
deb41fa
to
0fc9e65
Compare
|
I'm glad to see this fixed, but it introduces broken links to the standard library docs, and it has no test cases. To write the test cases, use the |
|
Looks like this has broken pretty much every other relative link 😅 |
This comment has been minimized.
This comment has been minimized.
clubby789
force-pushed
the
relative-module-fix
branch
2 times, most recently
from
79bfc53
to
cb0c746
Compare
notriddle
approved these changes
Jan 6, 2023
|
@bors r+ rollup |
|
📌 Commit cb0c7466ad48b337eb3711cf5aa443013096fedd has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
clubby789
force-pushed
the
relative-module-fix
branch
from
cb0c746
to
d5d1c57
Compare
|
Cleaned up the |
|
@bors r+ rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 7, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106287 (Add some docs to `bug`, `span_bug` and `delay_span_bug`) - rust-lang#106341 (refactor: clean up `errors.rs` and `error_codes_check.rs`) - rust-lang#106453 (Improve include macro documentation) - rust-lang#106466 (Fix rustdoc source code rendering for `#[path = "../path/to/mod.rs"]` links) - rust-lang#106528 (Tiny formatting fix) - rust-lang#106534 (rustdoc-gui: Use new block syntax for define-function in goml scripts) - rust-lang#106542 (Add default and latest stable edition to --edition in rustc (attempt 2)) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103517
While generating the location for modules source HTML to be saved at, a
..path component appeared to be translated to/up/.Additionally, while generating the navigation sidebar,
..path components were ignored. This means that (as in the issue above), a real directory structure of:was rendered as:
While the files were stored as