Tweak E0277 &-removal suggestions
#106360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nagisa (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
estebank
force-pushed
the
remove-borrow-suggestion
branch
from
f248375
to
ef4991f
Compare
estebank
force-pushed
the
remove-borrow-suggestion
branch
from
ef4991f
to
f69e968
Compare
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
remove-borrow-suggestion
branch
from
774c4a1
to
906f43a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
estebank
force-pushed
the
remove-borrow-suggestion
branch
from
906f43a
to
8393019
Compare
Comment on lines
+1308
to
+1369
| while let Some((c, Some(parent_trait_pred))) = code.parent() { | ||
| // We want the root obligation, in order to detect properly handle | ||
| // `for _ in &mut &mut vec![] {}`. | ||
| code = c; | ||
| trait_pred = parent_trait_pred; | ||
| } |
There was a problem hiding this comment.
is there some sort of peel method that does this lol
There was a problem hiding this comment.
We have a few (blame me for the nomenclature :P) but I think not for this ^_^'
|
@bors r+ |
|
📌 Commit 8393019ce977995825aec81c301d9414f27d41d9 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
estebank
force-pushed
the
remove-borrow-suggestion
branch
from
8393019
to
8b8cce1
Compare
|
@bors r=compiler-errors |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 12, 2023
… r=compiler-errors Tweak E0277 `&`-removal suggestions Fix rust-lang#64068, fix rust-lang#84837.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jan 12, 2023
… r=compiler-errors Tweak E0277 `&`-removal suggestions Fix rust-lang#64068, fix rust-lang#84837.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#103236 (doc: rewrite doc for signed int::{carrying_add,borrowing_sub}) - rust-lang#103800 (Stabilize `::{core,std}::pin::pin!`) - rust-lang#106097 (Migrate mir_build diagnostics 2 of 3) - rust-lang#106170 (Move autoderef to `rustc_hir_analysis`) - rust-lang#106323 (Stabilize f16c_target_feature) - rust-lang#106360 (Tweak E0277 `&`-removal suggestions) - rust-lang#106524 (Label `struct/enum constructor` instead of `fn item`, mention that it should be called on type mismatch) - rust-lang#106739 (Remove `<dyn AstConv<'tcx>>::fun(c, ...)` calls in favour of `c.astconv().fun(...)`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #64068, fix #84837.