Some compare_method tweaks
#106129
Merged
Some compare_method tweaks
#106129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nilstrieb (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
compiler-errors
commented
Dec 24, 2022
| @@ -16,28 +16,8 @@ LL | type B<'a, 'b> where 'a: 'b; | |||
| LL | type B<'a, 'b> = (&'a(), &'b ()) where 'b: 'a; | |||
| | ^^ impl has extra requirement `'b: 'a` | |||
|
|
|||
| error[E0478]: lifetime bound not satisfied | |||
There was a problem hiding this comment.
This error is now not emitted since we return ErrorGuaranteed in compare_type_predicate_entailment, which means we never get to check_type_bounds which is where this error is reported.
|
The changes look good but I'm not familiar with the code so I'll r? types for further review. |
compiler-errors
force-pushed
the
compare_method-tweaks
branch
from
e994705
to
96d8011
Compare
|
@bors r+ nice to see my FIXME get FIXME'd |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Dec 28, 2022
This was referenced Dec 28, 2022
|
Finished benchmarking commit (83a28ef): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 29, 2022
…n-err, r=estebank Make trait/impl `where` clause mismatch on region error a bit more actionable Improve `where` clause suggestions for GATs/methods that have incompatible region predicates in their `where` clauses. Also addresses this diagnostic that went away rust-lang#106129 (comment)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 29, 2022
…n-err, r=estebank Make trait/impl `where` clause mismatch on region error a bit more actionable Improve `where` clause suggestions for GATs/methods that have incompatible region predicates in their `where` clauses. Also addresses this diagnostic that went away rust-lang#106129 (comment)
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…s, r=BoxyUwU Some `compare_method` tweaks 1. Make some of the comparison functions' names more regular 2. Reduce pub scope of some of the things in `compare_method` ~3. Remove some unnecessary opaque type handling code -- `InferCtxt` already is in a mode that doesn't define opaque types~ * moved to a different PR 4. Bubble up `ErrorGuaranteed` for region constraint errors in `compare_method` - Improves a redundant error message in one unit test. 5. Move the `compare_method` module to have a more general name, since it's more like `compare_impl_item` :) 6. Rename `collect_trait_impl_trait_tys`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compare_method3. Remove some unnecessary opaque type handling code --InferCtxtalready is in a mode that doesn't define opaque typesErrorGuaranteedfor region constraint errors incompare_method- Improves a redundant error message in one unit test.compare_methodmodule to have a more general name, since it's more likecompare_impl_item:)collect_trait_impl_trait_tys