Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct branch-protection ModFlagBehavior for Aarch64 on LLVM-15 #105932

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Correct branch-protection ModFlagBehavior for Aarch64 on LLVM-15 #105932

merged 2 commits into from
Dec 22, 2022

Commits on Dec 20, 2022

  1. Correct ModFlagBehavior for Aarch64 on LLVM-15 

    When building with Fat LTO and BTI enabled on aarch64, the BTI is set to
`Module::Min` for alloc shim but is set to `Module::Error` for the
crate. This was fine when we were using LLVM-14 but LLVM-15 changes it's
behaviour to support for compiling with different `mbranch-protection`
flags.

Refer:
rust-lang/llvm-project@b0343a3
    @MasterAwesome
    MasterAwesome committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    55c4164 View commit details
    Browse the repository at this point in the history

  2. Use Error behavior for LLVM versions prior to 15 

    CI fails when building with LLVM-13. This raises unknown behavior
constant `8` from IRVerifier.
    @MasterAwesome
    MasterAwesome committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    5480ac5 View commit details
    Browse the repository at this point in the history