Make integer-to-integer From impls #[inline(always)]

[eduardosm]

Splited from #105262

[rustbot]

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

[eduardosm]

I'm not sure if I need special permissions to do this

@bors try @rust-timer queue

[scottmcm]

With MIR inlining on, it's less obvious to me whether these are still important, but let's see.

@bors try @rust-timer queue

[bors]

⌛ Trying commit 2e51122 with merge f342a343db8ef070ca9bba87b8a43e9a2cf082de...

[bors]

☀️ Try build successful - checks-actions
Build commit: f342a343db8ef070ca9bba87b8a43e9a2cf082de (f342a343db8ef070ca9bba87b8a43e9a2cf082de)

[rust-timer]

Finished benchmarking commit (f342a343db8ef070ca9bba87b8a43e9a2cf082de): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[1.6%, 2.8%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[1.6%, 2.8%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

[scottmcm]

Given no instruction or cycles results either way, this seems fine. These are so trivial that they're implicit it lots of language, so making sure there no function overhead seems plausible.

@bors r+ rollup=iffy

[bors]

📌 Commit 2e51122 has been approved by scottmcm

It is now in the queue for this repository.

[bors]

⌛ Testing commit 2e51122 with merge 023b513...

[bors]

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing 023b513 to master...

[rust-timer]

Finished benchmarking commit (023b513): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0