Simplify checking for GeneratorKind::Async
#104951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
fbstj
reviewed
Nov 26, 2022
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
fbstj
reviewed
Nov 26, 2022
Swatinem
changed the title
GeneratorKind::Async
|
r? @compiler-errors as you are already reviewing, feel free to reassign back to me |
|
@rustbot author let me know what u think about the suggestions! |
rustbot
added
S-waiting-on-author
Sounds good, just hadn’t had time today. |
rustbot
added
the
T-bootstrap
Adds a helper method around `generator_kind` that makes matching async constructs simpler.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 29, 2022
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#104465 (Document more settings for building rustc for Fuchsia) - rust-lang#104951 (Simplify checking for `GeneratorKind::Async`) - rust-lang#104959 (Revert rust-lang#104269 (to avoid spurious hang/test failure in CI)) - rust-lang#104978 (notify the rust-analyzer team on changes to the rust-analyzer subtree) - rust-lang#105010 (Fix documentation of asymptotic complexity for rustc_data_structures::SortedMap) - rust-lang#105016 (Add sentence when rustdoc search is running) - rust-lang#105020 (rustdoc: merge background-image rules in rustdoc-toggle CSS) - rust-lang#105024 (rustdoc: remove `fnname` CSS class that's styled exactly like `fn`) - rust-lang#105027 (Rustdoc-Json: Add tests for linking to foreign variants.) - rust-lang#105038 (Clean up pr 104954) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper method around
generator_kindthat makes matching async constructs simpler.