Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match and enforce crate and slug names #104120

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Match and enforce crate and slug names #104120

merged 4 commits into from
Nov 21, 2022

Conversation

mejrs
Copy link
Contributor

@mejrs mejrs commented Nov 7, 2022

Some of these were in the wrong place or had a name that didn't match.

@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eholk (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 7, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2022

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@mejrs mejrs changed the title Match crate and slug names Match and enforce crate and slug names Nov 7, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@davidtwco
Copy link
Member

r? @davidtwco

@rustbot rustbot assigned davidtwco and unassigned eholk Nov 8, 2022
@bors

This comment was marked as resolved.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 14, 2022

📌 Commit edeb64d964447ea8b3a5c51086f557b332be9054 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2022
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2022
@mejrs
Copy link
Contributor Author

mejrs commented Nov 15, 2022

rebased

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2022
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2022

📌 Commit fdb953c5870e2fad5c241cbbf6bb7e05c71a2f65 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2022
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 18, 2022

📌 Commit ce1e031468946981db716b0ded30a8ce803140a1 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2022
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 18, 2022
@mejrs
Copy link
Contributor Author

mejrs commented Nov 19, 2022

Can this get some priority? I fear I'll be rebasing until the end of days otherwise

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 19, 2022
@bors
Copy link
Contributor

bors commented Nov 21, 2022

☔ The latest upstream changes (presumably #104655) made this pull request unmergeable. Please resolve the merge conflicts.

@davidtwco
Copy link
Member

@bors p=1

@mejrs
Copy link
Contributor Author

mejrs commented Nov 21, 2022

I had to rebase first 😅

@rustbot ready

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 21, 2022

📌 Commit f47abd8 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2022
@bors
Copy link
Contributor

bors commented Nov 21, 2022

⌛ Testing commit f47abd8 with merge b7bc90f...

@bors
Copy link
Contributor

bors commented Nov 21, 2022

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing b7bc90f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 21, 2022
@bors bors merged commit b7bc90f into rust-lang:master Nov 21, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 21, 2022
This was referenced Nov 21, 2022
Merged
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b7bc90f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-2.3%, -2.2%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eholk eholk eholk left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mejrs @rustbot @rust-log-analyzer @davidtwco @bors @rust-timer @eholk