Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional float constants #103836

Merged
merged 1 commit into from Aug 28, 2023
Merged

Add additional float constants #103836

merged 1 commit into from Aug 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 1, 2022

Initial implementation of this ACP: rust-lang/libs-team#119. [Accepted]
Tracking issue: #103883

The values for the constants are copied from the libstdc++ source code.

@rustbot
Copy link
Collaborator

rustbot commented Nov 1, 2022

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 1, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 1, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@ghost
Copy link
Author

ghost commented Nov 1, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 1, 2022
@leonardo-m
Copy link

leonardo-m commented Nov 1, 2022

SQRT_3 is useful.
Sometimes in rust code I have also defined:

const LN_3: f64 = 1.0986122886681098;

@ghost ghost mentioned this pull request Nov 2, 2022
3 tasks
@ghost
Copy link
Author

ghost commented Nov 2, 2022

I've left the addition of ln(3) (and potential others) as an open question on the tracking issue: #103883

This PR just includes the ones in C++ but not Rust, as discussed in the ACP: rust-lang/libs-team#119 (comment)

@pitaj
Copy link
Contributor

pitaj commented Jan 29, 2023

@rustbot label -S-waiting-on-review +S-waiting-on-ACP

@rustbot rustbot added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2023
@pitaj pitaj added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Jun 27, 2023
@Dylan-DPC
Copy link
Member

r? @thomcc

@rustbot rustbot assigned thomcc and unassigned joshtriplett Jul 27, 2023
@thomcc
Copy link
Member

thomcc commented Aug 28, 2023

This has ACP+ and these are unstable, so

@bors r+

@bors
Copy link
Contributor

bors commented Aug 28, 2023

📌 Commit f7dec78 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2023
@bors
Copy link
Contributor

bors commented Aug 28, 2023

⌛ Testing commit f7dec78 with merge 1bd0430...

@bors
Copy link
Contributor

bors commented Aug 28, 2023

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 1bd0430 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2023
@bors bors merged commit 1bd0430 into rust-lang:master Aug 28, 2023
1 check passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 28, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1bd0430): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.2% [1.2%, 1.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.6% [1.6%, 1.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.5% [-4.5%, -2.6%] 2
All ❌✅ (primary) 1.6% [1.6%, 1.6%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.9% [1.3%, 2.4%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.432s -> 630.025s (-0.22%)
Artifact size: 316.28 MiB -> 316.26 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants