Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multivalue target feature to WASM target #103638

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Add multivalue target feature to WASM target #103638

merged 1 commit into from
Nov 2, 2022

Conversation

ia0
Copy link
Contributor

@ia0 ia0 commented Oct 27, 2022 •
edited
Loading

This PR is similar to #99643 and #97808. It addresses #96472 for the multivalue target feature.

The problem I am trying to fix is to remove the following warning when compiling with -C target-feature=+multivalue for --target=wasm32-unknown-unknown.

warning: unknown feature specified for `-Ctarget-feature`: `multivalue`
  |
  = note: it is still passed through to the codegen backend
  = note: consider filing a feature request

@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2022

r? @nagisa

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 27, 2022
@nagisa
Copy link
Member

nagisa commented Oct 28, 2022

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Oct 28, 2022

📌 Commit dad28ad has been approved by nagisa

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2022
@Manishearth Manishearth mentioned this pull request Nov 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2022
@bors
Auto merge of rust-lang#103857 - Manishearth:rollup-709fui6, r=Manish…
a876a4d 
…earth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#103072 (compiletest: set the dylib path when gathering target cfg)
 - rust-lang#103084 (Derive `Eq` and `Hash` for `ControlFlow`)
 - rust-lang#103575 (Change #[suggestion_*] attributes to use style="...")
 - rust-lang#103637 (Use stdio in UWP apps)
 - rust-lang#103638 (Add `multivalue` target feature to WASM target)
 - rust-lang#103781 (Detect unused files in `src/test/mir-opt` and error on them in tidy.)
 - rust-lang#103837 (Migrate sidebar-links-color GUI test to functions)
 - rust-lang#103839 (Print valid `--print` requests if request is invalid)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2cfab1f into rust-lang:master Nov 2, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 2, 2022
@ia0 ia0 deleted the multivalue branch November 3, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ia0 @rustbot @nagisa @bors