Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context to compiler error message #103307

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Add context to compiler error message #103307

merged 2 commits into from
Nov 10, 2022

Conversation

b4den
Copy link

@b4den b4den commented Oct 20, 2022

Changed creates a temporary which is freed while still in use to creates a temporary value which is freed while still in use.

Add context to compiler error message
c87567c 
Changed `creates a temporary which is freed while still in use` to
`creates a temporary value which is freed while still in use`
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 20, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Oct 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@inquisitivecrystal inquisitivecrystal added A-diagnostics Area: Messages for errors, warnings, and lints and removed A-testsuite Area: The testsuite used to check the correctness of rustc labels Oct 20, 2022
@cjgillot
Copy link
Contributor

cjgillot commented Nov 1, 2022

Hi @b4den, could you explain why you are making this change?
cc @estebank

@b4den
Copy link
Author

b4den commented Nov 1, 2022

Hi @b4den, could you explain why you are making this change? cc @estebank

Hey @cjgillot, this change helps bring consistency to the compiler error message when describing temporary values. For example, the phrase creates a temporary was missing the thing it was describing (in this case value).

@fmease
Copy link
Member

fmease commented Nov 9, 2022 •
edited
Loading

the phrase creates a temporary was missing the thing it was describing (in this case value).

Grammatically speaking, the word temporary can also be a noun, not only an adjective (e.g. see Merriam-Webster & Wiktionary). According to Wiktionary as linked, a temporary may refer to “a temporary variable”.

@estebank
Copy link
Contributor

estebank commented Nov 9, 2022

In compiler parlance "temporary" has a specific meaning, but compiler jargon shouldn't be leaking to the users. "Temporary value" is a good compromise.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 9, 2022

📌 Commit 6cb6564 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 9, 2022
@Manishearth
Rollup merge of rust-lang#103307 - b4den:master, r=estebank
bcc1781 
Add context to compiler error message

Changed `creates a temporary which is freed while still in use` to `creates a temporary value which is freed while still in use`.
@Manishearth Manishearth mentioned this pull request Nov 9, 2022
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 9, 2022
@Manishearth
Rollup merge of rust-lang#103307 - b4den:master, r=estebank
54c5061 
Add context to compiler error message

Changed `creates a temporary which is freed while still in use` to `creates a temporary value which is freed while still in use`.
@Manishearth Manishearth mentioned this pull request Nov 9, 2022
Closed
@Manishearth Manishearth mentioned this pull request Nov 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 9, 2022
@bors
Auto merge of rust-lang#104215 - Manishearth:rollup-5r957ad, r=Manish…
34115d0 
…earth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#101005 (Migrate rustc_codegen_llvm to SessionDiagnostics)
 - rust-lang#103307 (Add context to compiler error message)
 - rust-lang#103464 (Add support for custom mir)
 - rust-lang#103929 (Cleanup Apple-related code in rustc_target)
 - rust-lang#104015 (Remove linuxkernel targets)
 - rust-lang#104020 (Limit efiapi calling convention to supported arches)
 - rust-lang#104156 (Cleanups in autoderef impl)
 - rust-lang#104171 (Update books)
 - rust-lang#104184 (Fix `rustdoc --version` when used with download-rustc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 46bc12c into rust-lang:master Nov 10, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
9 participants
@b4den @rust-highfive @rust-log-analyzer @rustbot @cjgillot @fmease @estebank @bors @inquisitivecrystal