Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #![allow(rustc::potential_query_instability)] from rustc_infer #103218

Merged
merged 1 commit into from
Nov 7, 2022

Commits on Oct 28, 2022

  1. Remove #![allow(rustc::potential_query_instability)] from rustc_infer

    Change reported_violations to use IndexSet
    
    It is being used to iterate and to insert, without a lot of lookups
    so hopefully it won't be a perf hit
    
    Change MiniGraph.nodes to use IndexSet
    
    It is being used to iterate and to insert, without performing lookups
    so hopefully it won't be a perf hit
    
    Change RegionConstraintData.givens to a FxIndexSet
    
    This might result in a perf hit. Remove was being used in `givens`,
    and `FxIndexSet` doesn't allow calling remove without losing the
    fixed iteration order. So it was necessary to change remove to
    `shift_remove`, but this method is slower.
    
    Change OpaqueTypesVisitor to use stable sets and maps
    
    This could also be a perf hit.
    
    Make TraitObject visitor use a stable set
    CastilloDel committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    e950201 View commit details
    Browse the repository at this point in the history