Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce subst_iter and subst_iter_copied on EarlyBinder #103123

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Oct 16, 2022

Makes working with bounds lists a bit easier, which I seem to do a lot.

Specifically, means that we don't need to do .transpose_iter().map(|(pred, _)| *pred) every time we want to iterate through an EarlyBinder<&'tcx [(Predicate, Span)]> (and even then, still have to call subst later), which was a very awkward idiom imo.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 16, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-highfive
Copy link
Collaborator

r? @eholk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2022
@bors
Copy link
Contributor

bors commented Oct 21, 2022

☔ The latest upstream changes (presumably #103310) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 22, 2022

📌 Commit aa8931c has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2022
notriddle added a commit to notriddle/rust that referenced this pull request Oct 22, 2022
… r=cjgillot

Introduce `subst_iter` and `subst_iter_copied` on `EarlyBinder`

Makes working with bounds lists a bit easier, which I seem to do a lot.

Specifically, means that we don't need to do `.transpose_iter().map(|(pred, _)| *pred)` every time we want to iterate through an `EarlyBinder<&'tcx [(Predicate, Span)]>` (and even then, still have to call `subst` later), which was a very awkward idiom imo.
notriddle added a commit to notriddle/rust that referenced this pull request Oct 22, 2022
… r=cjgillot

Introduce `subst_iter` and `subst_iter_copied` on `EarlyBinder`

Makes working with bounds lists a bit easier, which I seem to do a lot.

Specifically, means that we don't need to do `.transpose_iter().map(|(pred, _)| *pred)` every time we want to iterate through an `EarlyBinder<&'tcx [(Predicate, Span)]>` (and even then, still have to call `subst` later), which was a very awkward idiom imo.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 22, 2022
… r=cjgillot

Introduce `subst_iter` and `subst_iter_copied` on `EarlyBinder`

Makes working with bounds lists a bit easier, which I seem to do a lot.

Specifically, means that we don't need to do `.transpose_iter().map(|(pred, _)| *pred)` every time we want to iterate through an `EarlyBinder<&'tcx [(Predicate, Span)]>` (and even then, still have to call `subst` later), which was a very awkward idiom imo.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#103123 (Introduce `subst_iter` and `subst_iter_copied` on `EarlyBinder` )
 - rust-lang#103328 (Do not suggest trivially false const predicates)
 - rust-lang#103354 (Escape string literals when fixing overlong char literal)
 - rust-lang#103355 (Handle return-position `impl Trait` in traits properly in `register_hidden_type`)
 - rust-lang#103368 (Delay ambiguity span bug in normalize query iff not rustdoc)
 - rust-lang#103388 (rustdoc: remove unused CSS class `.result-description`)
 - rust-lang#103399 (Change `unknown_lint` applicability to `MaybeIncorrect`)
 - rust-lang#103401 (Use functions for headings rustdoc GUI test)
 - rust-lang#103412 (Fix typo in docs of `String::leak`.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5290d5e into rust-lang:master Oct 23, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 23, 2022
@compiler-errors compiler-errors deleted the early-binder-iter branch November 2, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants