Enable inline stack probes on X86 with LLVM 16 #102503
Conversation
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
r? @nagisa |
cuviper
force-pushed
the
x86-stack-probes
branch
from
e6f8a2e
to
ed9e6f2
Compare
|
You mention all the known issues. I wonder if it would be worthwhile to reference the known ones here? @bors r+ either way. |
bors
added
S-waiting-on-bors
| @@ -635,6 +635,10 @@ pub enum StackProbeType { | |||
| } | |||
|
|
|||
| impl StackProbeType { | |||
| // LLVM X86 targets (ix86 and x86_64) can use inline-asm stack probes starting with LLVM 16. | |||
| // Notable past issues were rust#83139 (fixed in 14) and rust#84667 (fixed in 16). | |||
There was a problem hiding this comment.
This is the reference I made to known issues, which were also mentioned in the distributed comments that I removed.
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (607b829): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Enable inline stack probes on X86 with LLVM 16 The known problems with x86 inline-asm stack probes have been solved on LLVM main (16), so this flips the switch. Anyone using bleeding-edge LLVM with rustc can start testing this, as I have done locally. We'll get more direct rust-ci when LLVM 16 branches and we start our upgrade, and we can always patch or disable it then if we find new problems. The previous attempt was rust-lang#77885, reverted in rust-lang#84708.
The known problems with x86 inline-asm stack probes have been solved on LLVM main (16), so this flips the switch. Anyone using bleeding-edge LLVM with rustc can start testing this, as I have done locally. We'll get more direct rust-ci when LLVM 16 branches and we start our upgrade, and we can always patch or disable it then if we find new problems.
The previous attempt was #77885, reverted in #84708.