rustdoc: clean up "normalize.css 8" input override CSS #102436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Sep 28, 2022
|
Thanks! @bors r+ rollup |
|
📌 Commit b8dadfcaeb06fc4a7ea614b2a3dfcc2a1896ab54 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
notriddle
force-pushed
the
notriddle/normalize-form
branch
from
b8dadfc
to
f55ea41
Compare
These rules were copied from normalize.css 3, and are mostly redundant. * `optgroup` isn't used in rustdoc at all * `textarea` is only used for the "copy" button, so it's not visible * The remaining buttons and inputs mostly have styles set anyway. * We should never be setting `color` without also setting the background to something. Otherwise, you get white-on-gray text. That seems to be [the reason] why `normalize.css` changed this. [the reason]: necolas/normalize.css#502
|
@bors r=GuillaumeGomez rollup |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Sep 29, 2022
…, r=GuillaumeGomez rustdoc: clean up "normalize.css 8" input override CSS These rules were copied from normalize.css 3, and are mostly redundant. * `optgroup` isn't used in rustdoc at all * `textarea` is only used for the "copy" button, so it's not visible * The remaining buttons and inputs mostly have styles set anyway. * We should never be setting `color` without also setting the background to something. Otherwise, you get white-on-gray text. That seems to be [the reason] why `normalize.css` changed this. [the reason]: necolas/normalize.css#502
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Sep 29, 2022
…, r=GuillaumeGomez rustdoc: clean up "normalize.css 8" input override CSS These rules were copied from normalize.css 3, and are mostly redundant. * `optgroup` isn't used in rustdoc at all * `textarea` is only used for the "copy" button, so it's not visible * The remaining buttons and inputs mostly have styles set anyway. * We should never be setting `color` without also setting the background to something. Otherwise, you get white-on-gray text. That seems to be [the reason] why `normalize.css` changed this. [the reason]: necolas/normalize.css#502
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 29, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#102336 (Fix associated type bindings with anon const in GAT position) - rust-lang#102342 (Add negation methods for signed non-zero integers.) - rust-lang#102385 (Don't export `__heap_base` and `__data_end` on wasm32-wasi.) - rust-lang#102435 (Improve example of Iterator::reduce) - rust-lang#102436 (rustdoc: clean up "normalize.css 8" input override CSS) - rust-lang#102452 (fix minor ungrammatical sentence) - rust-lang#102455 (Use let-chaining in `WhileTrue::check_expr`.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules were copied from normalize.css 3, and are mostly redundant.
optgroupisn't used in rustdoc at alltextareais only used for the "copy" button, so it's not visiblecolorwithout also setting the background to something. Otherwise, you get white-on-gray text. That seems to be the reason whynormalize.csschanged this.