Only generate closure def id for async fns with body #102244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
commented
Sep 24, 2022
| let closure_id = match asyncness { | ||
| Async::Yes { closure_id, .. } => closure_id, | ||
| Async::No => return self.lower_fn_body_block(span, decl, body), | ||
| let (closure_id, body) = match (asyncness, body) { |
There was a problem hiding this comment.
This means that when a (non-trait) async fn is lacking a body, we now lower it to <ExprKind::Err> instead of wrapping it in an async block first. This will not affect any code that currently compiles though.
cjgillot
reviewed
Sep 25, 2022
| // def-id for it. | ||
| if body.is_some() { | ||
| let closure_def = self.create_def(closure_id, DefPathData::ClosureExpr, span); | ||
| self.with_parent(closure_def, |this| walk_list!(this, visit_block, body)); |
There was a problem hiding this comment.
Could you use an if let Some and avoid the walk_list here?
|
r? @cjgillot |
compiler-errors
force-pushed
the
issue-102219
branch
from
4043bb5
to
e99f6fe
Compare
|
@bors r=cjgillot |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2022
…fee1-dead Rollup of 4 pull requests Successful merges: - rust-lang#101851 (Clean up (sub)diagnostic derives) - rust-lang#102244 (Only generate closure def id for async fns with body) - rust-lang#102263 (Clarify Iterator::rposition code example) - rust-lang#102280 (rustdoc: clean up `.out-of-band`/`.in-band` CSS) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102219