Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate more of rustc_parse to SessionDiagnostic #101619

Merged
merged 16 commits into from
Sep 28, 2022
Merged

Migrate more of rustc_parse to SessionDiagnostic #101619

merged 16 commits into from
Sep 28, 2022

Commits on Sep 27, 2022

  1. Migrate rustc_session::expr_parentheses_needed to Subdiagnostic struct

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    495e271 View commit details
    Browse the repository at this point in the history

  2. Implement IntoDiagnosticArg for rustc_ast::Path

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    8489a67 View commit details
    Browse the repository at this point in the history

  3. Allow raw identifiers to be used as fluent arguments

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    4d02892 View commit details
    Browse the repository at this point in the history

  4. Migrate more diagnostics in rustc_parse to diagnostic structs

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    ab7c7dc View commit details
    Browse the repository at this point in the history

  5. Migrate "invalid literal suffix" diagnostic to diagnostic structs

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    6ae7a30 View commit details
    Browse the repository at this point in the history

  6. Move rustc_parse diagnostic structs to separate module

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    e56d6a6 View commit details
    Browse the repository at this point in the history

  7. Migrate more rustc_parse diagnostics to diagnostic structs

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    e1b1d7b View commit details
    Browse the repository at this point in the history

  8. Remove error condition in parse_attribute 

    This function is only ever called when the `#` has already been
consumed, no need to produce an error message here.
    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    4d0519a View commit details
    Browse the repository at this point in the history

  9. Rework "inner attribute not permitted" errors

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    21b5194 View commit details
    Browse the repository at this point in the history

  10. Migrate "expected identifier" diagnostics to diagnostic structs

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    7507ee2 View commit details
    Browse the repository at this point in the history

  11. Migrate "expected semicolon" diagnostics to diagnostic structs

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    ba10f2c View commit details
    Browse the repository at this point in the history

  12. Migrate "struct literal body without path" error to diagnostic struct

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    760c435 View commit details
    Browse the repository at this point in the history

  13. Migrate even more diagnostics in rustc_parse to diagnostic structs

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    00f9546 View commit details
    Browse the repository at this point in the history

  14. Document use of Symbol::to_string()

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    caefac0 View commit details
    Browse the repository at this point in the history

  15. Don't unnecessarily stringify paths in diagnostics

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    37fdcb4 View commit details
    Browse the repository at this point in the history

  16. Implement IntoDiagnosticArg for rustc_ast::token::Token(Kind)

    @Xiretza
    Xiretza committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    d7c6457 View commit details
    Browse the repository at this point in the history