Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve crate selection on rustdoc search results page #100374

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Improve crate selection on rustdoc search results page #100374

merged 4 commits into from
Aug 12, 2022

Commits on Aug 10, 2022

  1. Improve crate selection on rustdoc search results page 

    Resolves all of issue rust-lang#93240

Reproduces a similar change as rust-lang#99086, but with improvements

In particular, this PR inlcludes:
* redesigning the crate-search selector so the background color matches its surroundings
* decrease the font of the dropdown menu to a reaonable size
* add a hover effect
* make the color of the arrow theme-dependent, using a surrounding div, with :after pseudo-element
  that can then be transformed using CSS filters to approximate the desired color
* fix the text "in" to match the title font
* remove the "for xyz" in the "Results for xyz in [All crates]" title when
  searching for search term "xyz"; you can already see what you're searching for
  as it's typed in the search bar!
* in line with rust-lang#99086, handle super-long crate names appropriately without a long <select>
  element escaping the screen area; the improvement is that we also keep the title
  within a single line now; uses some flex layout shenanigans...
* the margins / paddings are adjusted so the selected label of the <select> fits within
  the rest of that title nicely; also some inconsistency in the way that Firefox renders
  a <select> with "appearance: none" (roughly 4px more padding left and right of the text
  than e.g. Chrome) is worked around, and it now produces a result that looks (essentially)
  identical to Chrome
* the color of the help menu and settings menu border in light theme is made to match with
  the color of the corresponding buttons, like they do (match) in the ayu theme
* the casing of "All crates" changes to "all crates"
* the new tests from rust-lang#99086 are temporarily disabled, until they can be adapted later
    @steffahn @GuillaumeGomez
    steffahn authored and GuillaumeGomez committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    16bcc18 View commit details
    Browse the repository at this point in the history

  2. Two small improvements: 

    Fix oversight duplicate property left in CSS (dark theme).

Improve wording in comment that mentions `appearance: none`
    @steffahn @GuillaumeGomez
    steffahn authored and GuillaumeGomez committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    e957480 View commit details
    Browse the repository at this point in the history

  3. Add missing ID into the ID map

    @GuillaumeGomez
    GuillaumeGomez committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    107e039 View commit details
    Browse the repository at this point in the history

  4. Update GUI test

    @GuillaumeGomez
    GuillaumeGomez committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    ea05be2 View commit details
    Browse the repository at this point in the history