Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv process tests are ignored #9341

Closed
alexcrichton opened this issue Sep 19, 2013 · 0 comments · Fixed by #9578
Closed

libuv process tests are ignored #9341

alexcrichton opened this issue Sep 19, 2013 · 0 comments · Fixed by #9578
Assignees
@alexcrichton

Comments

@alexcrichton
Copy link
Member

It turns out that libuv processes register SIGCHLD handlers, but these handlers aren't registered with SA_RESTART, so when we receive a SIGCHLD syscalls are interrupted and std::io doesn't handle the EINTR return value. Currently the tests which exercise libuv process bindings are ignored, and they currently aren't used anywhere else in the code.

We have two options to un-ignore these tests

  1. Teach all of std::io and various libc bindings to handle EINTR
  2. Wait for std::io to be removed.

I'm in favor of option 2, but mainly just because it means that it's less effort :)
@ghost ghost assigned alexcrichton Sep 19, 2013
@alexcrichton alexcrichton mentioned this issue Sep 27, 2013
Merged
bors added a commit that referenced this issue Oct 2, 2013
@bors
auto merge of #9578 : alexcrichton/rust/un-ignore-libuv-process-tests…
88b0b51 
…, r=brson

Closes #9341
Jarcho pushed a commit to Jarcho/rust that referenced this issue Aug 29, 2022
@bors
Auto merge of rust-lang#9341 - bmc-msft:suggest-map_or-instead-of-unw…
18c6818 
…rap_or, r=giraffate

suggest map_or in case_sensitive_file_extension_comparisons

changelog: [`case_sensitive_file_extension_comparisons `]: updated suggestion in the example to use `map_or`

Currently, case_sensitive_file_extension_comparisons suggests using `map(..).unwrap_or(..)` which trips up the `map_unwrap_or` lint.  This updates the suggestion to use `map_or`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move the rt::io::process tests to run-pass alexcrichton/rust
1 participant
@alexcrichton