[Internal Compiler Error] occurred when compiling eww with latest nightly build (2022-01-21) #93197
Comments
Animeshz
added
C-bug
Animeshz
changed the title
|
@Animeshz would you be able to test if #93180 would fix your issue ? (it doesn't seem to fix other similar issues, but maybe it will fix this one), by following these steps:
Thanks in advance. |
|
@Animeshz PRs are only built on-demand, so either when the bots test and merge it after review, or when someone asks manually for a The latter is what I did here. The bot leaves a comment with the hash when/if the build is successful. In this case it is It would be helpful if you could also try However, it's likely that neither of these will fix the exact issue you're having. Someone has tried them on |
|
d634ef421795e0140724aa9fddf8137b83e616c9 didn't worked unfortunately, I'll try to find |
|
Okay, so the area of problem is shorten down, and it exactly happens when there's a Result unwrapping at here, i.e.: |
|
This however works fine: match evt_send.send(app::DaemonCommand::NoOp) {
Ok(v) => v,
Err(e) => {
return Err(e);
}
}compiler/rustc_ast_lowering/src/expr.rs:1431 might have some significance in this issue 👀 (I guess?). |
rustbot
added
E-needs-mcve
|
Hey Cleanup Crew ICE-breakers! This bug has been identified as a good cc @AminArria @ayazhafiz @camelid @chrissimpkins @contrun @elshize @h-michael @HallerPatrick @hdhoang @hellow554 @henryboisdequin @imtsuki @JamesPatrickGill @kanru @KarlK90 @matheus-consoli @mental32 @nmccarty @Noah-Kennedy @pard68 @PeytonT @pierreN @Redblueflame @RobbieClarken @RobertoSnap @robjtede @SarthakSingh31 @shekohex @sinato @smmalis37 @steffahn @Stupremee @tamuhey @turboladen @woshilapin @yerke |
|
Here we go: unwrap-ice-repro.zip |
|
That's a great first step, thanks. It still relies on |
|
@rustbot claim |
|
Taking some time to look closer at this now. It looks like where this is crashing is not covered by #93165, so I will work on a proper fix or disabling PR. |
The previous PR, rust-lang#93165, still performed the drop range analysis despite ignoring the results. Unfortunately, there were ICEs in the analysis as well, so some packages failed to build (see the issue rust-lang#93197 for an example). This change further disables the analysis and just provides dummy results in that case.
|
I haven't gotten as much time to look into this today as I'd hope, but I did at least prepare a PR that disables the drop range analysis (#93284) and I've confirmed that eww builds with that change. |
|
@eholk please add this testcase to your PR: #![feature(try_blocks)]
use std::sync::{mpsc, mpsc::SendError};
pub async fn foo() {
let (tx, _) = mpsc::channel();
let _: Result<(), SendError<&str>> = try { tx.send("hello")?; };
}
fn main() {}This also panics on stable. Feel free to add the |
…pnkfelix Disable drop range analysis The previous PR, rust-lang#93165, still performed the drop range analysis despite ignoring the results. Unfortunately, there were ICEs in the analysis as well, so some packages failed to build (see the issue rust-lang#93197 for an example). This change further disables the analysis and just provides dummy results in that case.
Builds fails only with the latest (yesterday released)
rustc 1.60.0-nightly (17d29dcdc 2022-01-21) running on x86_64-unknown-linux-gnucompiler. Tested with 2022-01-20 compiler and it works all okay!Code
For now: refer to elkowar/eww:crates/eww/src/script_var_handler.rs#L137. I'll update if I'm able to minimize where actually the rustc panics.
<code>Meta
rustc --version --verbose:Error output
eww on master [✘] via via 🦀 v1.60.0-nightly >>> cargo build --release ... Compiling gdk-pixbuf v0.14.0 Compiling gdk v0.14.3 warning: the feature `format_args_capture` has been stable since 1.58.0 and no longer requires an attribute to enable --> crates/simplexpr/src/lib.rs:2:12 | 2 | #![feature(format_args_capture)] | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(stable_features)]` on by default Compiling gdkx11 v0.14.0 warning: `simplexpr` (lib) generated 1 warning Building [=======================> ] 364/366: gtk Bu Compiling eww v0.2.0 (/home/animesh/Projects/RustProjects/eww/crates/eww) thread 'rustc' panicked at 'Expression ID not found', compiler/rustc_typeck/src/check/generator_interior/drop_ranges/cfg_build.rs:468:52 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace error: internal compiler error: unexpected panic note: the compiler unexpectedly panicked. this is a bug. note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md note: rustc 1.60.0-nightly (17d29dcdc 2022-01-21) running on x86_64-unknown-linux-gnu note: compiler flags: -C opt-level=3 -C embed-bitcode=no --crate-type bin note: some of the compiler flags provided by cargo are hidden query stack during panic: #0 [typeck] type-checking `script_var_handler::<impl at crates/eww/src/script_var_handler.rs:131:1: 179:2>::start` #1 [mir_built] building MIR for `script_var_handler::<impl at crates/eww/src/script_var_handler.rs:131:1: 179:2>::start` end of query stack error: could not compile `eww`Backtrace
The text was updated successfully, but these errors were encountered: