Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DICompileUnit not listed in llvm.dbg.cu #90045

Closed
glandium opened this issue Oct 19, 2021 · 4 comments
Closed

DICompileUnit not listed in llvm.dbg.cu #90045

glandium opened this issue Oct 19, 2021 · 4 comments
Labels
C-bug Category: This is a bug. P-medium Medium priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@glandium
Copy link
Contributor

STR:

  • Create a dummy crate: cargo new hello ; cd hello
  • Build with profiling and LTO enabled: CARGO_INCREMENTAL=0 cargo +nightly rustc -- -Zprofile -Cdebuginfo=2 -Clto -Cembed-bitcode=yes

This fails with the following error message:

DICompileUnit not listed in llvm.dbg.cu
!34 = distinct !DICompileUnit(language: DW_LANG_Rust, file: !13, producer: "clang LLVM (rustc version 1.58.0-nightly (bd41e09da 2021-10-18))", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !35)
LLVM ERROR: Broken module found, compilation aborted!

Bisect says it is a regression from #89041.
@glandium glandium added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Oct 19, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 19, 2021
@JohnTitor JohnTitor added requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. and removed regression-untriaged Untriaged performance or correctness regression. labels Oct 20, 2021
@JohnTitor
Copy link
Member

Assigning P-medium as discussed as part of the Prioritization Working Group procedure and removing I-prioritize.

@JohnTitor JohnTitor added P-medium Medium priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Oct 20, 2021
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 26, 2021
@glandium
Bug 1742910 - Work around rust-lang/rust#90045. r=firefox-build-syste…
bb2a47f 
…m-reviewers,andi

Differential Revision: https://phabricator.services.mozilla.com/D132111
aosmond pushed a commit to aosmond/gecko that referenced this issue Nov 27, 2021
@glandium
Bug 1742910 - Work around rust-lang/rust#90045. r=firefox-build-syste…
6b299cc 
…m-reviewers,andi

Differential Revision: https://phabricator.services.mozilla.com/D132111
@Nemo157
Copy link
Member

Nemo157 commented Oct 21, 2022

This seems to compile successfully now on rustc 1.65.0-nightly (29e4a9ee0 2022-08-10).

@Noratrieb
Copy link
Member

@glandium can you confirm that this works now?

@glandium
Copy link
Contributor Author

glandium commented Apr 3, 2023

Last broken: rustc 1.64.0-nightly (23e21bd 2022-07-15)
First working: rustc 1.64.0-nightly (d5e7f47 2022-07-16)
(and yes, still works today)
Presumably, this was fixed by 98190b7, which is a revert of the commit pointed at by bisect.

@glandium glandium closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. P-medium Medium priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Nemo157 @glandium @JohnTitor @rustbot @Noratrieb