Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Source code sidebar should pin to selected file #73360

Closed
tesuji opened this issue Jun 15, 2020 · 0 comments · Fixed by #74325
Closed

rustdoc: Source code sidebar should pin to selected file #73360

tesuji opened this issue Jun 15, 2020 · 0 comments · Fixed by #74325
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@tesuji
Copy link
Contributor

tesuji commented Jun 15, 2020

For example this doc: https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_middle/macros.rs.html#2-7

When you click to the "<" button, it show the file structure and not scroll down to the current viewed file:
image
I expect to see rustdoc sidebar point to viewed file directly:
image
@LeSeulArtichaut LeSeulArtichaut added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 15, 2020
@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 14, 2020
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Jul 16, 2020
@Manishearth
Rollup merge of rust-lang#74325 - GuillaumeGomez:focus-source-file-si…
1c0f58a 
…debar, r=kinnison

Focus on the current file in the source file sidebar

Fixes rust-lang#73360.

r? @kinnison
cc @rust-lang/rustdoc
Manishearth added a commit to Manishearth/rust that referenced this issue Jul 16, 2020
@Manishearth
Rollup merge of rust-lang#74325 - GuillaumeGomez:focus-source-file-si…
0b6601d 
…debar, r=kinnison

Focus on the current file in the source file sidebar

Fixes rust-lang#73360.

r? @kinnison
cc @rust-lang/rustdoc
@bors bors closed this as completed in 196243e Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Focus on the current file in the source file sidebar GuillaumeGomez/rust
2 participants
@tesuji @LeSeulArtichaut