Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

also need a DeepClone impl for @T and @mut T where T is Send #6525

Closed
thestinger opened this issue May 16, 2013 · 3 comments
Closed

also need a DeepClone impl for @T and @mut T where T is Send #6525

thestinger opened this issue May 16, 2013 · 3 comments

Comments

@thestinger
Copy link
Contributor

This will conflict with the T: Freeze implementation for many types, so I don't think it's currently possible.
@emberian
Copy link
Member

Owned => Send.

Nominating for feature complete?

@catamorphism
Copy link
Contributor

Just a bug, de-nominating.

@thestinger
Copy link
Contributor Author

This will be dealt with by the move to Gc<T>.

flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 15, 2021
@bors
Auto merge of rust-lang#6525 - phansch:fix-bless-in-subdirs, r=flip1995
8951916 
Fix blessing of test output in subdirectories

The core issue was the usage of `reference_file_path.file_name()`, which
provided a non-existent path if the file to be updated was in a
subdirectory.

Instead we have to provide the whole path after 'tests/ui/' as the
'filename'. This part of the path is called `test_name` in the code now.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@catamorphism @emberian @thestinger