Rust 1.33.0 failing UI tests when run with single core #59122
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
O-guix
Operating system: Guix, https://www.gnu.org/software/guix/
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
jonas-schievink
added
A-testsuite
pnkfelix
added
the
T-compiler
|
I've managed to confirm that the issue occurs when the compiler is built with What is the process for creating the vendor directory when creating a source tarball of the compiler? Are there any tests that verify the right dependencies were vendored in? |
ipetkov
changed the title
|
Aha! I turns out it's not a vendoring issue, but rather a number of test threads issue! I was able to reproduce without vendoring, but by invoking the test suite with a single core: ./x.py test -vv -j1 src/test/run-fail # fails the two test cases above
./x.py test -vv src/test/run-fail # succeeds |
ipetkov
changed the title
This was referenced Oct 21, 2022
thomcc
pushed a commit
to tcdi/postgrestd
that referenced
this issue
Feb 10, 2023
libtest: run all tests in their own thread, if supported by the host This reverts the threading changes of rust-lang/rust#56243, which made it so that with `-j1`, the test harness does not spawn any threads. Those changes were done to enable Miri to run the test harness, but Miri supports threads nowadays, so this is no longer needed. Using a thread for each test is useful because the thread's name can be set to the test's name which makes panic messages consistent between `-j1` and `-j2` runs and also a bit more readable. I did not revert the HashMap changes of rust-lang/rust#56243; using a deterministic map seems fine for the test harness and the more deterministic testing is the better. Fixes rust-lang/rust#59122 Fixes rust-lang/rust#70492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to package/build Rust 1.33.0 on Guix and I'm consistently getting some test failures regarding panic messages.
Several run-fail tests check that a
#[test]with a name liketest_fooprints a message likethread 'test_foo' panicked..., but instead the output will come out asthread 'main' panicked....I'm not really sure what can be the cause of the issue, but FWIW we build Rust with the previous stable version already packaged in Guix, and we'll link to our packaged versions of llvm and jemalloc.
Happy to provide more details as needed; log from the failing test cases is below
< Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "compile-fail", suite: "compile-fail", path: Some("src/test/compile-fail"), compare_mode: None } < CompileFail { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } c Assemble { target_compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" } } > RunFail { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } > Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "run-fail", suite: "run-fail", path: Some("src/test/run-fail"), compare_mode: None } c Test { target: "x86_64-unknown-linux-gnu", compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" } } c Test { target: "x86_64-unknown-linux-gnu", compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" } } c TestHelpers { target: "x86_64-unknown-linux-gnu" } c TestHelpers { target: "x86_64-unknown-linux-gnu" } c RemoteCopyLibs { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } c Assemble { target_compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" } } c Compiletest { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } c Assemble { target_compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" } } c Llvm { target: "x86_64-unknown-linux-gnu", emscripten: false } c Sysroot { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" } } c Libdir { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } c Sysroot { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" } } c Llvm { target: "x86_64-unknown-linux-gnu", emscripten: false } Check compiletest suite=run-fail mode=run-fail (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) running: "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/src/test/run-fail" "--build-base" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/test/run-fail" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-fail" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/gnu/store/bvnj04sqiwc1gcis29swk6likyc5dw8f-llvm-6.0.1/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/gnu/store/g87hamjyipk1j6dfq5pjfzfnfb64spbv-python2-2.7.15/bin/python2" "--lldb-python" "/gnu/store/g87hamjyipk1j6dfq5pjfzfnfb64spbv-python2-2.7.15/bin/python2" "--gdb" "/gnu/store/pp6nvrw47ip2r54k4kyk5a8fhyxvhsb8-gdb-8.2/bin/gdb" "--verbose" "--quiet" "--llvm-version" "6.0.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" configuration: compile_lib_path: "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage2/lib" run_lib_path: "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" rustc_path: "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" rustdoc_path: None src_base: "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/src/test/run-fail" build_base: "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/test/run-fail" stage_id: stage2-x86_64-unknown-linux-gnu mode: run-fail run_ignored: false filter: (none) filter_exact: false runtool: (none) host-rustcflags: -Crpath -O -Zunstable-options -Lnative=/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/native/rust-test-helpers target-rustcflags: -Crpath -O -Zunstable-options -Lnative=/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/native/rust-test-helpers target: x86_64-unknown-linux-gnu host: x86_64-unknown-linux-gnu android-cross-path: "" adb_path: "adb" adb_test_dir: "/data/tmp/work" adb_device_status: false ar: ar linker: None verbose: true quiet: true
running 143 tests
.................................................................................................... 100/143
........................FF.................
failures:
---- [run-fail] run-fail/test-panic.rs stdout ----
executing "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/src/test/run-fail/test-panic.rs" "--target=x86_64-unknown-linux-gnu" "-C" "prefer-dynamic" "-o" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/test/run-fail/test-panic/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--test" "-L" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/test/run-fail/test-panic/auxiliary"
------stdout------------------------------
------stderr------------------------------
executing "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/test/run-fail/test-panic/a"
------stdout------------------------------
running 1 test
test test_foo ... FAILED
failures:
---- test_foo stdout ----
thread 'main' panicked at 'explicit panic', /tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/src/test/run-fail/test-panic.rs:8:5
note: Run with
RUST_BACKTRACE=1environment variable to display a backtrace.failures:
test_foo
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
------stderr------------------------------
error: error pattern 'thread 'test_foo' panicked at' not found!
status: exit code: 101
command: "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/test/run-fail/test-panic/a"
stdout:
running 1 test
test test_foo ... FAILED
failures:
---- test_foo stdout ----
thread 'main' panicked at 'explicit panic', /tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/src/test/run-fail/test-panic.rs:8:5
note: Run with
RUST_BACKTRACE=1environment variable to display a backtrace.failures:
test_foo
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
stderr:
thread '[run-fail] run-fail/test-panic.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
---- [run-fail] run-fail/test-should-fail-bad-message.rs stdout ----
executing "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/src/test/run-fail/test-should-fail-bad-message.rs" "--target=x86_64-unknown-linux-gnu" "-C" "prefer-dynamic" "-o" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/test/run-fail/test-should-fail-bad-message/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--test" "-L" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/test/run-fail/test-should-fail-bad-message/auxiliary"
------stdout------------------------------
------stderr------------------------------
executing "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/test/run-fail/test-should-fail-bad-message/a"
------stdout------------------------------
running 1 test
test test_foo ... FAILED
failures:
---- test_foo stdout ----
thread 'main' panicked at 'blah', /tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/src/test/run-fail/test-should-fail-bad-message.rs:9:5
note: Run with
RUST_BACKTRACE=1environment variable to display a backtrace.note: Panic did not include expected string 'foobar'
failures:
test_foo
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
------stderr------------------------------
error: error pattern 'thread 'test_foo' panicked at' not found!
status: exit code: 101
command: "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/test/run-fail/test-should-fail-bad-message/a"
stdout:
running 1 test
test test_foo ... FAILED
failures:
---- test_foo stdout ----
thread 'main' panicked at 'blah', /tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/src/test/run-fail/test-should-fail-bad-message.rs:9:5
note: Run with
RUST_BACKTRACE=1environment variable to display a backtrace.note: Panic did not include expected string 'foobar'
failures:
test_foo
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
stderr:
thread '[run-fail] run-fail/test-should-fail-bad-message.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
failures:
[run-fail] run-fail/test-panic.rs
[run-fail] run-fail/test-should-fail-bad-message.rs
test result: FAILED. 141 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out
thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:495:22
command did not execute successfully: "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/src/test/run-fail" "--build-base" "/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/test/run-fail" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-fail" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/gnu/store/bvnj04sqiwc1gcis29swk6likyc5dw8f-llvm-6.0.1/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/tmp/guix-build-rust-1.33.0.drv-0/rustc-1.33.0-src/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/gnu/store/g87hamjyipk1j6dfq5pjfzfnfb64spbv-python2-2.7.15/bin/python2" "--lldb-python" "/gnu/store/g87hamjyipk1j6dfq5pjfzfnfb64spbv-python2-2.7.15/bin/python2" "--gdb" "/gnu/store/pp6nvrw47ip2r54k4kyk5a8fhyxvhsb8-gdb-8.2/bin/gdb" "--verbose" "--quiet" "--llvm-version" "6.0.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" ""
expected success, got: exit code: 101
The text was updated successfully, but these errors were encountered: