Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

str api should offer a method to convert a &u8 slice into an &str with same lifetime #5422

Closed
nikomatsakis opened this issue Mar 18, 2013 · 4 comments
Closed

str api should offer a method to convert a &u8 slice into an &str with same lifetime #5422

nikomatsakis opened this issue Mar 18, 2013 · 4 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@nikomatsakis
Copy link
Contributor

Since strs and vecs share the same representation, there should be a way to "cast" a &u8 slice into an &str with the same lifetime.

There are a few FIXMEs in tydecode where this could save a copy.
@sanxiyn
Copy link
Member

sanxiyn commented Mar 18, 2013

Isn't this an unsafe operation? Not all &u8 are valid &str.

@nikomatsakis
Copy link
Contributor Author

I presumed there'd be an assertion as well as an unsafe variant, as we have for str::from_bytes

@huonw huonw mentioned this issue Mar 20, 2013
Closed
@Kimundi Kimundi mentioned this issue Apr 10, 2013
Merged
@bors bors closed this as completed in a3c8f52 Apr 27, 2013
@Kimundi
Copy link
Member

Kimundi commented May 24, 2013

@nikomatsakis Could you confirm the PR request did add what was wanted in this issue? I remembered that there where some difficulties to make it work because a &str slice has to cover one byte more than a &[].

@nikomatsakis
Copy link
Contributor Author

Looks good, thanks.

oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
@flip1995
Rollup merge of rust-lang#5422 - nickrtorres:contributing-triage, r=f…
b42bd19 
…lip1995

CONTRIBUTING.md: fix broken triage link

Fixes rust-lang#5421
oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5438 - flip1995:rollup-pi762oy, r=flip1995
f8308c8 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#5406 (Fix update_lints)
 - rust-lang#5409 (Downgrade let_unit_value to pedantic)
 - rust-lang#5410 (Downgrade trivially_copy_pass_by_ref to pedantic)
 - rust-lang#5412 (Downgrade inefficient_to_string to pedantic)
 - rust-lang#5415 (Add new lint for `Result<T, E>.map_or(None, Some(T))`)
 - rust-lang#5417 (Update doc links and mentioned names in docs)
 - rust-lang#5419 (Downgrade unreadable_literal to pedantic)
 - rust-lang#5420 (Downgrade new_ret_no_self to pedantic)
 - rust-lang#5422 (CONTRIBUTING.md: fix broken triage link)
 - rust-lang#5424 (Incorrect suspicious_op_assign_impl)
 - rust-lang#5425 (Ehance opt_as_ref_deref lint.)

Failed merges:

 - rust-lang#5345 (Add lint for float in array comparison)
 - rust-lang#5411 (Downgrade implicit_hasher to pedantic)
 - rust-lang#5428 (Move cognitive_complexity to nursery)

r? @ghost

changelog: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sanxiyn @nikomatsakis @Kimundi