Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for Unsafe Pointer Methods reform #43941

Closed
alexcrichton opened this issue Aug 17, 2017 · 9 comments · Fixed by #48259
Closed

Tracking issue for Unsafe Pointer Methods reform #43941

alexcrichton opened this issue Aug 17, 2017 · 9 comments · Fixed by #48259
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

This is a tracking issue for rust-lang/rfcs#1966

@gankro mind filling in this issue with a checklist of work items?
@alexcrichton alexcrichton added B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 17, 2017
@alexcrichton alexcrichton mentioned this issue Aug 17, 2017
Merged
@Gankra
Copy link
Contributor

Gankra commented Aug 17, 2017

Working on impl

@Gankra Gankra mentioned this issue Aug 17, 2017
Merged
@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Aug 20, 2017
@tinaun
Copy link
Contributor

tinaun commented Jan 20, 2018

is there anything blocking stabilization? its been a few cycles

@Gankra
Copy link
Contributor

Gankra commented Jan 21, 2018

This is probably safe to nominate for stabilization now. I would certainly love to use this.

@Mark-Simulacrum
Copy link
Member

Nominating for stabilization. I believe the relevant methods can all be found on this page of the documentation under the pointer_methods feature.

@alexcrichton
Copy link
Member Author

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Jan 23, 2018 •
edited by Kimundi
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jan 23, 2018
@SimonSapin
Copy link
Contributor

Ping @Kimundi

@rfcbot
Copy link

rfcbot commented Feb 14, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 14, 2018
@tinaun tinaun mentioned this issue Feb 16, 2018
Merged
@rfcbot
Copy link

rfcbot commented Feb 24, 2018

The final comment period is now complete.

tinaun added a commit to tinaun/rust that referenced this issue Mar 3, 2018
@tinaun
Stabilize Unsafe Pointer Methods
1011b8a 
also minor doc fixes.

Closes rust-lang#43941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize Unsafe Pointer Methods tinaun/rust
6 participants
@alexcrichton @SimonSapin @Gankra @tinaun @Mark-Simulacrum @rfcbot