Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various bugs in the rt debug interface #2667

Closed
graydon opened this issue Jun 21, 2012 · 0 comments
Closed

Various bugs in the rt debug interface #2667

graydon opened this issue Jun 21, 2012 · 0 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.
Milestone
old 1.0 milestone

Comments

@graydon
Copy link
Contributor

graydon commented Jun 21, 2012

There are alignment and wrong-structure bugs lurking in the debug interface in rust_builtin.cpp. Fix 'em.
@luqmana luqmana mentioned this issue Feb 13, 2013
Closed
bors added a commit that referenced this issue Feb 14, 2013
@bors
auto merge of #4915 : luqmana/rust/rt-cleanup, r=pcwalton
f06f68d 
Closes #1190.

Also, got rid of `rust_ptr_eq` since it isn't used any as well the `RUST_REFCOUNTED` macros.

Fixes #2667: alignment & wrong structure.
RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 15, 2022
@bors
Auto merge of rust-lang#2667 - RalfJung:josh, r=RalfJung
209bcbb 
adjust josh pushing, remove './miri toolchain HEAD/commit'

Looks like pushing works much better if we use as base commit the last commit we pulled from rustc and merged into Miri. Which I guess is fair. Conveniently, the `rust-version` file should usually be pretty much exactly that commit. Also adjust `rustc-pull` to update that file.

Pulling is now the way to update to a newer rustc, so I also removed `./miri toolchain HEAD`.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2667 - RalfJung:josh, r=RalfJung
ed72e77 
adjust josh pushing, remove './miri toolchain HEAD/commit'

Looks like pushing works much better if we use as base commit the last commit we pulled from rustc and merged into Miri. Which I guess is fair. Conveniently, the `rust-version` file should usually be pretty much exactly that commit. Also adjust `rustc-pull` to update that file.

Pulling is now the way to update to a newer rustc, so I also removed `./miri toolchain HEAD`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
2 participants
@graydon @pcwalton