compiletest: aggressive_rm_rf
might not be aggressive enough on non-Windows platforms
#126334
Labels
A-compiletest
Area: the compiletest test runner
A-run-make
Area: port run-make Makefiles to rmake.rs
C-bug
Category: This is a bug.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
rust/src/tools/compiletest/src/runtest.rs
Lines 3420 to 3441 in bbe9a9c
aggressive_rm_rf
seems to only account for read-only files in Windows (and tries really hard to rm -rf), but does not try as hard on Linux or macOS or other non-Windows platforms. This can pose issues to tests that modifies file or folder permissions in one way or another that could causefs::remove_file
to fail, which can lead to artifacts lingering around and cause tests results to not be reproducible.The text was updated successfully, but these errors were encountered: