-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conflicting impl since nightly-2024-05-01 #125763
Comments
Thank you for opening this issue! further minimized pub trait Overlap {}
impl<T: Overlap + ?Sized> Overlap for &'static T {}
impl<T: LabelSet> Overlap for T
where
for<'a> T::Value<'a>: LabelGroup,
{}
pub trait LabelGroup {}
pub trait LabelSet {
type Value<'a>;
} This pattern is #114061. Coherence now considers We use rust/compiler/rustc_trait_selection/src/traits/coherence.rs Lines 944 to 948 in d43930d
Sorry for not mentioning this in the original FCP. I was aware of this immediate breakage but did not mention it. Changing this to also be a future compat lint is annoying and I intentionally did not suggest this in #117164, as that is "inside of the trait solver" and has a smaller impact than the changes to the orphan check itself. I would like to not revert this change as there have been some small follow-up PRs and I want to close these unsoundnesses asap. I propose accepting this breakage and to close this issue after adding it as a test. However, given that this has slipped through the FCP process, I am open to revert and re-land with another FCP in case there are any concerns by a @rust-lang/types member. @rfcbot fcp close |
Team member @lcnr has proposed to close this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
I'd like to note that this kind of code would've gotten rejected with the stabilization of You can verify this yourself by running |
I'm fine with the decision but it would have been nicer to have some warning with info |
Yeah, that's understandable. Sorry about that! |
yes, we did no catch the breakage in your crate when running crater, unsure why that was the case 🤔
Generally we try to open fixes or at least issues to affected projects when landing breaking changes. This relies on us actually detecting these changes however 😅 |
Strange. This particular impl has been on crates.io since February 10 🤔 those crater runs were Feb-27 and Apr-27 respectively and |
yeah it's not the first time this happened, there's rust-lang/crater#727 and discussions on zulip IIRC |
@rfcbot reviewed
…On Thu, May 30, 2024, at 1:00 PM, Rémy Rakic wrote:
> yes, we did no catch the breakage in your crate when running crater, unsure why that was the case 🤔
>
yeah it's not the first time this happened, there's rust-lang/crater#727 <rust-lang/crater#727> and discussions on zulip IIRC
—
Reply to this email directly, view it on GitHub <#125763 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABF4ZWOU2HYIBT6YOVVZMDZE5LLFAVCNFSM6AAAAABIQPESU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQGI3TEOBWGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This comment was marked as outdated.
This comment was marked as outdated.
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to close, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. |
## Problem `cargo +nightly check` fails ## Summary of changes Updates `measured`, `time`, and `crc32c`. * `measured`: updated to fix rust-lang/rust#125763. * `time`: updated to fix rust-lang/rust#125319 * `crc32c`: updated to remove some nightly feature detection with a removed nightly feature
## Problem `cargo +nightly check` fails ## Summary of changes Updates `measured`, `time`, and `crc32c`. * `measured`: updated to fix rust-lang/rust#125763. * `time`: updated to fix rust-lang/rust#125319 * `crc32c`: updated to remove some nightly feature detection with a removed nightly feature
Code
I tried this code:
https://github.com/conradludgate/measured/tree/b2978b32e2065cb6257244829b5fd6ae1dba4576
I expected to see this happen: compiles successfully
Instead, this happened:
Version it worked on
It most recently worked on:
nightly-2024-04-30
Version with regression
according to cargo-bisect-rustc, the regression started with
nightly-2024-05-01
in #117164The text was updated successfully, but these errors were encountered: