Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define what the stability attributes mean #12203

Closed
emberian opened this issue Feb 12, 2014 · 7 comments
Closed

Define what the stability attributes mean #12203

emberian opened this issue Feb 12, 2014 · 7 comments

Comments

@emberian
Copy link
Member

Exactly what do each of the stability attributes mean?

I think #[stable] should mean "no change to this will break source compatability with safe code" and #[frozen] should mean "this type will not change in any way to break source or binary compatability with safe or unsafe code". This includes size and representation.

@emberian
Copy link
Member Author

Nominating for 1.0, this affects how we specify and maintain stability.

@brson
Copy link
Contributor

brson commented Feb 12, 2014

Just copy this somewhere Rusty http://nodejs.org/api/documentation.html#documentation_stability_index, with proper attribution of course. Though I think we should probably drop 'frozen' and 'locked' until we need them.

@emberian
Copy link
Member Author

I don't think locked is necessary, but I think frozen is definitely
necessary. I think having a separate level of stability for guaranteed ABI
compat is incredibly useful.

On Tue, Feb 11, 2014 at 9:16 PM, Brian Anderson notifications@github.comwrote:

Just copy this somewhere Rusty
http://nodejs.org/api/documentation.html#documentation_stability_index,
with proper attribution of course. Though I think we should probably drop
'frozen' and 'locked' until we need them.


Reply to this email directly or view it on GitHubhttps://github.com//issues/12203#issuecomment-34832159
.

@pnkfelix
Copy link
Member

We do need to define what these attributes mean for 1.0, as part of the docs 1.0. Accepted for P-backcompat-libs.

@huonw
Copy link
Member

huonw commented Mar 1, 2014

This exists: http://static.rust-lang.org/doc/master/rust.html#stability

The precise definitions could use some tuning (I just took them directly from NodeJS), but it's there...

@steveklabnik
Copy link
Member

Yup, they're here. They seem fine to me. Does this deserve an RFC or something? Can we close this?

@emberian
Copy link
Member Author

Yes.

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 8, 2024
…pt-param-file, r=flip1995

Makes clippy-driver check for --sysroot in arg files

Fixes rust-lang/rust-clippy#12201

---

changelog: none

cc: `@UebelAndre` `@illicitonion`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants