Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_unused in rustc_resolve references missing check_crate fn #119787

Closed
mj10021 opened this issue Jan 9, 2024 · 1 comment · Fixed by #119788
Closed

check_unused in rustc_resolve references missing check_crate fn #119787

mj10021 opened this issue Jan 9, 2024 · 1 comment · Fixed by #119788
Assignees
@mj10021
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools

Comments

@mj10021
Copy link
Contributor

mj10021 commented Jan 9, 2024 •
edited by rustbot
Loading

Location

compiler/rustc_resolve/src/check_unused.rs

Summary

on line 23 of check_crate is referenced

rust/compiler/rustc_resolve/src/check_unused.rs

Line 23 in 190f4c9

// - `check_crate` finally emits the diagnostics based on the data generated

but I cannot find a corresponding function, I believe the function that it is supposed to be referring to is check_unused on line 283

rust/compiler/rustc_resolve/src/check_unused.rs

Line 283 in 190f4c9

pub(crate) fn check_unused(&mut self, krate: &ast::Crate) {

@mj10021 mj10021 added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Jan 9, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 9, 2024
@mj10021
Copy link
Contributor Author

mj10021 commented Jan 9, 2024

@rustbot claim

@mj10021 mj10021 mentioned this issue Jan 9, 2024
Merged
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 11, 2024
@bors bors closed this as completed in 6238698 Jan 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 11, 2024
@rust-timer
Unrolled build for rust-lang#119788
545eb62 
Rollup merge of rust-lang#119788 - mj10021:issue-119787-fix, r=oli-obk

change function name in comments

fixes rust-lang#119787 where I believe an incorrect function name is used in the comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mj10021 mj10021

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change function name in comments mj10021/rust
3 participants
@mj10021 @saethlin @rustbot