Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for BufRead::skip_until #111735

Closed
2 of 3 tasks
WilliamVenner opened this issue May 18, 2023 · 7 comments · Fixed by #131267
Closed
2 of 3 tasks

Tracking Issue for BufRead::skip_until #111735

WilliamVenner opened this issue May 18, 2023 · 7 comments · Fixed by #131267
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting

Comments

@WilliamVenner
Copy link
Contributor

WilliamVenner commented May 18, 2023

Feature gate: #![feature(bufread_skip_until)]

This is a tracking issue for BufRead::skip_until, which is similar to BufRead::read_until but doesn't write data to an output buffer; it simply skips past it.

This is useful when, for example, reading a binary file format but wanting to skip some data, like a NUL-terminated string.

Public API

// trait BufRead

fn skip_until(&mut self, byte: u8) -> std::io::Result<usize>;

Steps / History

Unresolved Questions

  • None yet.

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html

@WilliamVenner WilliamVenner added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 18, 2023
@IS2511
Copy link

IS2511 commented Apr 11, 2024

Any updates? Just stumbled into a use-case for this and can't use nightly.

@WilliamVenner
Copy link
Contributor Author

@rustbot ping libs

Shall we FCP?

@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2024

Error: Only Rust team members can ping teams.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@dtolnay
Copy link
Member

dtolnay commented Aug 28, 2024

@rust-lang/libs-api:
@rfcbot fcp merge

https://doc.rust-lang.org/nightly/std/io/trait.BufRead.html#method.skip_until

@rfcbot
Copy link

rfcbot commented Aug 28, 2024

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Aug 28, 2024
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Sep 24, 2024
@rfcbot
Copy link

rfcbot commented Sep 24, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 4, 2024
@rfcbot
Copy link

rfcbot commented Oct 4, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Oct 4, 2024
@bors bors closed this as completed in 3078b23 Oct 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 5, 2024
Rollup merge of rust-lang#131267 - okaneco:bufread_skip_until, r=tgross35

Stabilize `BufRead::skip_until`

FCP completed rust-lang#111735 (comment)

Closes rust-lang#111735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants