Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable MIR inlining on beta-1.64 #101004

Closed
pnkfelix opened this issue Aug 25, 2022 · 3 comments
Closed

disable MIR inlining on beta-1.64 #101004

pnkfelix opened this issue Aug 25, 2022 · 3 comments
Assignees
@pnkfelix
Labels
P-critical Critical priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.64.0

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Aug 25, 2022 •
edited
Loading

As discussed in T-compiler meeting https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202022-08-25/near/295236517, we are going to disable MIR inlining on beta-1.64 in order to resolve issues like #100550 and #100476 without having to do semi-risky backports.

For reference, the PR that enabled MIR inlining was PR #91743
@pnkfelix pnkfelix self-assigned this Aug 25, 2022
@pnkfelix pnkfelix added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. P-critical Critical priority labels Aug 25, 2022
@apiraino apiraino mentioned this issue Aug 25, 2022
Merged
@Mark-Simulacrum Mark-Simulacrum added this to the 1.64.0 milestone Aug 25, 2022
@Mark-Simulacrum
Copy link
Member

cc #100550 (comment) (and subsequent comments) -- it doesn't look like that was discussed prior to agreeing to do this.

@pnkfelix
Copy link
Member Author

I opened a zulip thread to discuss this further: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/.28re.29debating.20disabling.20MIR-inlining.20on.201.2E64-beta.20.23101004/near/295256039

pnkfelix added a commit to pnkfelix/rust that referenced this issue Aug 26, 2022
@pnkfelix
revert mir inlining policy for beta-1.64 to resolve issue rust-lang#1…
63bb951 
…01004.
@pnkfelix pnkfelix mentioned this issue Aug 26, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 31, 2022
@bors
Auto merge of rust-lang#101050 - pnkfelix:revert-mir-inline-policy-fo…
1ec9b66 
…r-beta-1.64, r=compiler-errors

revert mir inlining policy for beta-1.64

revert mir inlining policy for beta-1.64

Fix rust-lang#101004
@pnkfelix
Copy link
Member Author

pnkfelix commented Sep 1, 2022 •
edited
Loading

resolved by merge of #101050

@pnkfelix pnkfelix closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnkfelix pnkfelix

Labels
P-critical Critical priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

No branches or pull requests
2 participants
@pnkfelix @Mark-Simulacrum