Skip to content

Commit

Permalink
improve attribute trailing semicolon error
Browse files Browse the repository at this point in the history
  • Loading branch information
csmoe committed Mar 17, 2018
1 parent a7170b0 commit 9f5a356
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 10 deletions.
11 changes: 1 addition & 10 deletions src/libsyntax/parse/attr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ impl<'a> Parser<'a> {
debug!("parse_attribute_with_inner_parse_policy: inner_parse_policy={:?} self.token={:?}",
inner_parse_policy,
self.token);
let (span, path, tokens, mut style) = match self.token {
let (span, path, tokens, style) = match self.token {
token::Pound => {
let lo = self.span;
self.bump();
Expand Down Expand Up @@ -129,15 +129,6 @@ impl<'a> Parser<'a> {
}
};

if inner_parse_policy == InnerAttributeParsePolicy::Permitted &&
self.token == token::Semi {
self.bump();
self.span_warn(span,
"this inner attribute syntax is deprecated. The new syntax is \
`#![foo]`, with a bang and no semicolon");
style = ast::AttrStyle::Inner;
}

Ok(ast::Attribute {
id: attr::mk_attr_id(),
style,
Expand Down
12 changes: 12 additions & 0 deletions src/test/ui/issue-49040.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![allow(unused_variables)]; //~ ERROR expected item, found `;`
fn main() {}
8 changes: 8 additions & 0 deletions src/test/ui/issue-49040.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
error: expected item, found `;`
--> $DIR/issue-49040.rs:11:28
|
LL | #![allow(unused_variables)]; //~ ERROR expected item, found `;`
| ^ help: consider removing this semicolon

error: aborting due to previous error

0 comments on commit 9f5a356

Please sign in to comment.