-
Notifications
You must be signed in to change notification settings - Fork 12.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated maybe_owned_vec with review feedback.
Namely: * Added conversion traits both to and from the various vector types, analogous to how `str::MaybeOwned` works with `str::IntoMaybeOwned` and `str::Str`. This led me to add the `FixedLen` variant of `MaybeOwnedVector` for interoperability with `std::slice`. * Revised client example code to make use of `into_maybe_owned` * Added implementations of `Show` and `CloneableVector` for `MaybeOwnedVector`. * As suggested by kballard, added `into_vec` method that is analogous to `CloneableVector::into_owned` except it produces a `Vec` rather than a `~[T]`.
- Loading branch information
Showing
2 changed files
with
96 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a122a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at pnkfelix@4a122a3
4a122a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging pnkfelix/rust/add-libgraphviz-crate = 4a122a3 into auto
4a122a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnkfelix/rust/add-libgraphviz-crate = 4a122a3 merged ok, testing candidate = 8600441a
4a122a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4743
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5535
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/4628
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4641
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5637
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4725
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4733
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5639
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/4724
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4730
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2526
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5633
4a122a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at pnkfelix@4a122a3
4a122a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging pnkfelix/rust/add-libgraphviz-crate = 4a122a3 into auto
4a122a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnkfelix/rust/add-libgraphviz-crate = 4a122a3 merged ok, testing candidate = 485998d4
4a122a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4732
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5541
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5537
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4643
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5639
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4727
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4735
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5641
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2528
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5635
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4745