-
Notifications
You must be signed in to change notification settings - Fork 12.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
resolve: Future-proof against imports referring to local variables an…
…d generic parameters
- Loading branch information
1 parent
696fbc0
commit 22a13ef
Showing
3 changed files
with
134 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
// edition:2018 | ||
|
||
#![feature(uniform_paths, underscore_imports)] | ||
|
||
mod T { | ||
pub struct U; | ||
} | ||
mod x { | ||
pub struct y; | ||
} | ||
|
||
fn type_param<T>() { | ||
use T as _; //~ ERROR imports cannot refer to type parameters | ||
use T::U; //~ ERROR imports cannot refer to type parameters | ||
use T::*; //~ ERROR imports cannot refer to type parameters | ||
} | ||
|
||
fn self_import<T>() { | ||
use T; // FIXME Should be an error, but future-proofing fails due to `T` being "self-shadowed" | ||
} | ||
|
||
fn let_binding() { | ||
let x = 10; | ||
|
||
use x as _; //~ ERROR imports cannot refer to local variables | ||
use x::y; // OK | ||
use x::*; // OK | ||
} | ||
|
||
fn param_binding(x: u8) { | ||
use x; //~ ERROR imports cannot refer to local variables | ||
} | ||
|
||
fn match_binding() { | ||
match 0 { | ||
x => { | ||
use x; //~ ERROR imports cannot refer to local variables | ||
} | ||
} | ||
} | ||
|
||
fn nested<T>() { | ||
let x = 10; | ||
|
||
use {T as _, x}; //~ ERROR imports cannot refer to type parameters | ||
//~| ERROR imports cannot refer to local variables | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
error: imports cannot refer to type parameters | ||
--> $DIR/future-proofing-locals.rs:13:9 | ||
| | ||
LL | use T as _; //~ ERROR imports cannot refer to type parameters | ||
| ^ | ||
|
||
error: imports cannot refer to type parameters | ||
--> $DIR/future-proofing-locals.rs:14:9 | ||
| | ||
LL | use T::U; //~ ERROR imports cannot refer to type parameters | ||
| ^ | ||
|
||
error: imports cannot refer to type parameters | ||
--> $DIR/future-proofing-locals.rs:15:9 | ||
| | ||
LL | use T::*; //~ ERROR imports cannot refer to type parameters | ||
| ^ | ||
|
||
error: imports cannot refer to local variables | ||
--> $DIR/future-proofing-locals.rs:25:9 | ||
| | ||
LL | use x as _; //~ ERROR imports cannot refer to local variables | ||
| ^ | ||
|
||
error: imports cannot refer to local variables | ||
--> $DIR/future-proofing-locals.rs:31:9 | ||
| | ||
LL | use x; //~ ERROR imports cannot refer to local variables | ||
| ^ | ||
|
||
error: imports cannot refer to local variables | ||
--> $DIR/future-proofing-locals.rs:37:17 | ||
| | ||
LL | use x; //~ ERROR imports cannot refer to local variables | ||
| ^ | ||
|
||
error: imports cannot refer to type parameters | ||
--> $DIR/future-proofing-locals.rs:45:10 | ||
| | ||
LL | use {T as _, x}; //~ ERROR imports cannot refer to type parameters | ||
| ^ | ||
|
||
error: imports cannot refer to local variables | ||
--> $DIR/future-proofing-locals.rs:45:18 | ||
| | ||
LL | use {T as _, x}; //~ ERROR imports cannot refer to type parameters | ||
| ^ | ||
|
||
error: aborting due to 8 previous errors | ||
|