Skip to content

Commit

Permalink
Rollup merge of #70927 - GuillaumeGomez:cleanup-e0510, r=Dylan-DPC
Browse files Browse the repository at this point in the history
Clean up E0510 explanation

r? @Dylan-DPC
  • Loading branch information
Dylan-DPC committed Apr 8, 2020
2 parents bad8f0b + 80e3126 commit 1498da8
Showing 1 changed file with 20 additions and 7 deletions.
27 changes: 20 additions & 7 deletions src/librustc_error_codes/error_codes/E0510.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,29 @@
Cannot mutate place in this match guard.
The matched value was assigned in a match guard.

When matching on a variable it cannot be mutated in the match guards, as this
could cause the match to be non-exhaustive:
Erroneous code example:

```compile_fail,E0510
let mut x = Some(0);
match x {
None => (),
Some(_) if { x = None; false } => (),
Some(v) => (), // No longer matches
None => {}
Some(_) if { x = None; false } => {} // error!
Some(_) => {}
}
```

When matching on a variable it cannot be mutated in the match guards, as this
could cause the match to be non-exhaustive.

Here executing `x = None` would modify the value being matched and require us
to go "back in time" to the `None` arm.
to go "back in time" to the `None` arm. To fix it, change the value in the match
arm:

```
let mut x = Some(0);
match x {
None => {}
Some(_) => {
x = None; // ok!
}
}
```

0 comments on commit 1498da8

Please sign in to comment.