Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix span for or_fun_call #9144

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Fix span for or_fun_call #9144

merged 3 commits into from
Jul 11, 2022

Conversation

alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented Jul 10, 2022 •
edited by giraffate
Loading

Closes #9033
changelog: [or_fun_call]: span points to the unwrap_or only instead of through the entire method chain expression

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 10, 2022
giraffate
giraffate reviewed Jul 11, 2022
View reviewed changes
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks! I made one comment.

clippy_lints/src/methods/or_fun_call.rs Outdated Show resolved Hide resolved
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Jul 11, 2022

📌 Commit c3c4cda has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 11, 2022

⌛ Testing commit c3c4cda with merge 8a62b6f...

@bors
Copy link
Collaborator

bors commented Jul 11, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 8a62b6f to master...

@bors bors merged commit 8a62b6f into rust-lang:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giraffate giraffate giraffate left review comments

Assignees

@giraffate giraffate

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve span of or_fun_call lint
4 participants
@alex-semenyuk @rust-highfive @giraffate @bors