Add await_holding_invalid_type lint
#8707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: [`await_holding_invalid_type`] This lint allows users to create a denylist of types which are not allowed to be held across await points. This is essentially a re-implementation of the language-level [`must_not_suspend` lint](rust-lang/rust#83310). That lint has a lot of work still to be done before it will reach Rust stable, and in the meantime there are a lot of types which can trip up developers if they are used improperly.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
llogiq
approved these changes
Apr 18, 2022
| let await_holding_invalid_types = conf.await_holding_invalid_types.clone(); | ||
| store.register_late_pass(move || { | ||
| Box::new(await_holding_invalid::AwaitHolding::new( | ||
| await_holding_invalid_types.clone(), |
There was a problem hiding this comment.
Suggested change
| await_holding_invalid_types.clone(), | |
| await_holding_invalid_types, |
No need for double clone, right?
There was a problem hiding this comment.
I tried this initially but borrowck doesn't like it
error[E0507]: cannot move out of `await_holding_invalid_types`, a captured variable in an `Fn` closure
--> clippy_lints/src/lib.rs:519:88
|
518 | let await_holding_invalid_types = conf.await_holding_invalid_types.clone();
| --------------------------- captured outer variable
519 | store.register_late_pass(move || Box::new(await_holding_invalid::AwaitHolding::new(await_holding_invalid_types)));
| ----------------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^--
| | |
| | move occurs because `await_holding_invalid_types` has type `std::vec::Vec<DisallowedType>`, which does not implement the `Copy` trait
| captured by this `Fn` closure
Co-authored-by: llogiq <bogusandre@gmail.com>
Co-authored-by: llogiq <bogusandre@gmail.com>
Co-authored-by: llogiq <bogusandre@gmail.com>
llogiq
reviewed
Apr 18, 2022
|
Thank you! ❤️ @bors r+ |
|
📌 Commit 0508685 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
await_holding_invalid_type]This lint allows users to create a denylist of types which are not allowed to be
held across await points. This is essentially a re-implementation of the
language-level
must_not_suspendlint. That lint has a lot of
work still to be done before it will reach Rust stable, and in the meantime
there are a lot of types which can trip up developers if they are used
improperly.
I originally implemented this specifically for
tracing::span::Entered, until I discovered #8434 and read the commentary on that PR. Given this implementation is fully user configurable, doesn't tie clippy to any one particular crate, and introduces no additional dependencies, it seems more appropriate.