Don't lint useless_transmute on types with erased regions
#8564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @camsteffen (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #8610) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'll take a look at this one @xFrednet |
|
Thank you, @Alexendoo, with this one you can r+ it once you think it looks good 🙃 @bors delegate=Alexendoo |
|
✌️ @Alexendoo can now approve this pull request |
Jarcho
force-pushed
the
transmute_erase_regions
branch
from
b301ffd
to
0c6ebf1
Compare
Alexendoo
approved these changes
May 31, 2022
|
@bors r+ |
|
📌 Commit 0c6ebf1 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6356
fixes #3340
fixes #2906
This should get a proper fix at some point, but this at least gets the lint running on some types.
cc #5343
changelog: Don't lint
useless_transmuteon types with erased regions