Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pulldown-cmark version #8168

Closed

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive
Copy link

r? @xFrednet

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 25, 2021
@xFrednet
Copy link
Member

Thanks for the PR the change look good to me. For Clippy we usually update the dependencies in rust-lang/rust and then sync it back into this repo. We do this to ensure that it builds in rust-lang/rust and that we don't use different versions of crates than other tools. Would you mind making this change in rust-lang/rust? You can also add it to rust-lang/rust#92252 and ping me to approve the Clippy changes there 🙃.

@GuillaumeGomez
Copy link
Member Author

I see, will do it like this then!

@GuillaumeGomez GuillaumeGomez deleted the pulldown-cmark branch December 25, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants