Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger [wrong_self_convention] only if it has implicit self #7215

Merged
merged 1 commit into from
May 13, 2021

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented May 13, 2021

Lint [wrong_self_convention] only if the impl or trait has self per sé.

Fixes: #7179

changelog: trigger [wrong_self_convention] only if it has implicit self

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 13, 2021
@Manishearth
Copy link
Member

@bors r+

oops

@bors
Copy link
Collaborator

bors commented May 13, 2021

📌 Commit cd241b3 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented May 13, 2021

⌛ Testing commit cd241b3 with merge 5267007...

bors added a commit that referenced this pull request May 13, 2021
Trigger [`wrong_self_convention`] only if it has implicit self

Lint [`wrong_self_convention`] only if the impl or trait has `self` _per sé_.

Fixes: #7179

changelog: trigger [`wrong_self_convention`] only if it has implicit self
@bors
Copy link
Collaborator

bors commented May 13, 2021

💔 Test failed - checks-action_test

@Manishearth
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented May 13, 2021

⌛ Testing commit cd241b3 with merge 08ce8bb...

@bors
Copy link
Collaborator

bors commented May 13, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 08ce8bb to master...

@bors bors merged commit 08ce8bb into rust-lang:master May 13, 2021
@ThibsG ThibsG deleted the WrongSelfFix7179 branch May 13, 2021 16:48
bors added a commit that referenced this pull request May 13, 2021
Add sized trait for `wrong_self_convention` lint test

This has been solved a few hours ago by #7215 😉

Fixes: #7219

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong_self_convention wrongly detects s: Self as self
4 participants