Pass Clippy args also trough RUSTFLAGS #6441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
flip1995
reviewed
Dec 12, 2020
I don't blame you, this is an ugly hack :) but I think for the moment it's a big win in usability. I think you already got it, but the general idea is to pass our args twice, once in |
ebroto
added
S-waiting-on-author
Also: enable tests for cargo-clippy
ebroto
force-pushed
the
use_rustflags
branch
from
767c947
to
f93d965
Compare
|
@bors r+ Thanks! |
|
📌 Commit f93d965 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Dec 22, 2020
Revert "Pass Clippy args also trough RUSTFLAGS" Reverts #6441 r? `@ebroto` changelog: Revert "Pass Clippy args also trough RUSTFLAGS"
ghost
mentioned this pull request
bors
added a commit
that referenced
this pull request
Mar 8, 2021
Let Cargo track CLIPPY_ARGS This PR makes `clippy-driver` emit `CLIPPY_ARGS` in its `dep-info` output. Just like #6441, this allows this workflow to work: ```shell cargo clippy # warning: empty `loop {}` wastes CPU cycles cargo clippy -- -A clippy::empty_loop # no warnings emitted ``` But without rebuilding all dependencies. cc https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/CLIPPY_ARGS.20is.20not.20tracked.20by.20Cargo/near/228599088 Changelog: Cargo now re-runs Clippy if arguments after `--` provided to `cargo clippy` are changed.
bors
added a commit
that referenced
this pull request
Mar 8, 2021
Let Cargo track CLIPPY_ARGS This PR makes `clippy-driver` emit `CLIPPY_ARGS` in its `dep-info` output. Just like #6441, this allows this workflow to work: ```shell cargo clippy # warning: empty `loop {}` wastes CPU cycles cargo clippy -- -A clippy::empty_loop # no warnings emitted ``` But without rebuilding all dependencies. cc https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/CLIPPY_ARGS.20is.20not.20tracked.20by.20Cargo/near/228599088 changelog: Cargo now re-runs Clippy if arguments after `--` provided to `cargo clippy` are changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a hack (__CLIPPY_HACKERY__) to add another one :)
It allows this workflow to work:
Before this change the new flag was not taken into consideration in cargo's fingerprint and the warning was emitted again. I guess that ideally we could add a specific env var for compiler wrapper arguments, but in the meantime this should do the job.
changelog: Pass clippy arguments through RUSTFLAGS so that changing them will trigger a rebuild
r? @flip1995
cc @ehuss (I think this may count as another step towards stabilizing
RUSTC_WORKSPACE_WRAPPER😄)Fixes #5214 and avoids frustration for users unfamiliar with the issue