Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint items after statements in local macro expansions #6176

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

achris
Copy link
Contributor

@achris achris commented Oct 15, 2020

The items_after_statements lint was skipping all expansions. Instead
we should still lint local macros.

Fixes #578


Please keep the line below
changelog: The items_after_statements now applies to local macro expansions

The items_after_statements lint was skipping all expansions.  Instead
we should still lint local macros.

Fixes rust-lang#578
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @phansch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 15, 2020
@achris achris changed the title Lint items after statements in macro expansions Lint items after statements in local macro expansions Oct 15, 2020
@phansch
Copy link
Member

phansch commented Oct 29, 2020

@bors r+ thanks!

@bors
Copy link
Collaborator

bors commented Oct 29, 2020

📌 Commit 32e2021 has been approved by phansch

@bors
Copy link
Collaborator

bors commented Oct 29, 2020

⌛ Testing commit 32e2021 with merge ee9da9a...

@bors
Copy link
Collaborator

bors commented Oct 29, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing ee9da9a to master...

@bors bors merged commit ee9da9a into rust-lang:master Oct 29, 2020
@achris achris deleted the issues/578 branch October 30, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

also lint on items after statements in macros
4 participants